[Bug 29148] New: Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Bug ID: 29148 Summary: Holds to Pull doesn't reflect item-level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To test: - have an item with multiple copies - place an item-level hold on one of the copies - go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl) - confirm it shows "[one of the barcodes] or any available" when it should show specifically the barcode of the item on which your hold was placed and should not show "or any available" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 125566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125566&action=edit Bug 29148: Check reserves.item_level_hold in Holds to Pull To test: 1 - place an item level hold 2 - go to Holds to Pull, see it shows "[barcode] or any available" 3- apply patch, restart 4- reload Holds to Pull, see it shows "only [barcode]" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm honestly not sure why the existing code started to fail here, but I changed it to check for item_level_hold=1, rather than presence of an itemnumber. It seems like a more reliable check anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Azucena Aguayo <azucena.aguayo@uvu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo@uvu.edu --- Comment #3 from Azucena Aguayo <azucena.aguayo@uvu.edu> --- Patch solves the item-level hold issue. However, patch breaks title-level hold barcode display. To test: - have an 2 records with multiple copies - place an item-level hold on one of the copies for record A - place a title-level hold for record B - go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl) - confirm it shows "only barcode" on BOTH holds when it should show specifically the barcode of one item on the hold for record A, but show the same on the title hold for record B. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Depends on| |24488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125566|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 125572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125572&action=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125572|0 |1 is obsolete| | --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 125573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125573&action=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available Signed-off-by: Azucena <Azucena.Aguayo@uvu.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Azucena Aguayo <azucena.aguayo@uvu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125573|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125664&action=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available Signed-off-by: Azucena <Azucena.Aguayo@uvu.edu> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 24488 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 [Bug 29786] Holds to pull report shows incorrect item for item level holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 [Bug 29161] Holds to pull should show item level holds only if available -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org