[Bug 28037] New: Improve breadcrumbs of CSV profiles page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Bug ID: 28037 Summary: Improve breadcrumbs of CSV profiles page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl, testopia@bugs.koha-community.org Depends on: 27846 The breadcrumbs menu on the CSV profiles page can be expanded to provide additional context for various operations. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118836&action=edit Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 28037: Improve breadcrumbs of CSV profiles page fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt). error: could not build fake ancestor Patch failed at 0001 Bug 28037: Improve breadcrumbs of CSV profiles page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". --------- Patch not applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Amit Gupta from comment #2)
Patch not applied.
Did you apply all the dependencies? You have to have Bug 27846. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Amit Gupta <amitddng135@gmail.com> --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 28037: Improve breadcrumbs of CSV profiles page fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt). error: could not build fake ancestor Patch failed at 0001 Bug 28037: Improve breadcrumbs of CSV profiles page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ------------------------------------------------------------------------ Patch not applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Depends on Bug 27846. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118836|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 118948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118948&action=edit Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes: - The patch and dependency (27846) applied fine for me. - Need to update the CSS for the staff interface (see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This makes me wonder a few things: - Should we be using Edit or Modify? Do we have a preferred term or does it not matter? - It now reads: "Modify a CSV profile" Looking at other pages, should this just be "Modify CSV profile"? (see news) - Or should we even try to include the name of the profile we also do sometimes? "Edit CSV profile '...' (see itemtypes) Still going to pass QA as this is definitely a step in the right direction and an improvement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118948|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119158&action=edit Bug 28037: Improve breadcrumbs of CSV profiles page This patch expands the logic around the page title and breadcrumbs of the CSV profiles page. The name of the page has also been changed from "CSV export profiles" to "CSV profiles" to match links elsewhere in Koha. To test, apply the patch and go to Tools -> CSV profiles. - The initial state of the page title and breadcrumbs menu should be "Tools > CSV profiles." - Click "New CSV profile." The page title and breadcrumbs should show "Tools > CSV profiles > New CSV profile." - Edit an existing CSV profile. The page title and breadcrumbs should show "Tools > CSV profiles > Modify a CSV profile." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch expands the release notes| |logic around the page title | |and breadcrumbs of the CSV | |profiles page. The name of | |the page has also been | |changed from "CSV export | |profiles" to "CSV profiles" | |to match links elsewhere in | |Koha. | | | |Breadcrumbs now | |display as: | |- Initial | |window: Tools > CSV | |profiles | |- New CSV profile: | |Tools > CSV profiles > New | |CSV profile | |- Edit an | |existing CSV profile: Tools | |> CSV profiles > Modify a | |CSV profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28037 --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #8)
This makes me wonder a few things:
- Should we be using Edit or Modify? Do we have a preferred term or does it not matter?
- It now reads: "Modify a CSV profile" Looking at other pages, should this just be "Modify CSV profile"? (see news)
- Or should we even try to include the name of the profile we also do sometimes? "Edit CSV profile '...' (see itemtypes)
Still going to pass QA as this is definitely a step in the right direction and an improvement.
I have added Bug 28184 for this. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org