[Bug 17635] New: (Bug 6934 followup) Templates missing body id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Bug ID: 17635 Summary: (Bug 6934 followup) Templates missing body id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 [Bug 6934] New report Cash Register Statistics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57513&action=edit Bug 17635: Fix templates with missing body id The following template files are missing body id and class and should be fixed: - members/housebound.tt - reports/cash_register_stats.tt To test: - Run: $ sudo koha-shell kohadev ; cd kohaclone k$ prove xt/tt_valid.t => FAIL: Tests fail due to the mentioned templates - Apply this patch - Run: $ sudo koha-shell kohadev ; cd kohaclone k$ prove xt/tt_valid.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57513|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57514&action=edit Bug 17635: Fix templates with missing body id The following template files are missing body id and class and should be fixed: - members/housebound.tt - reports/cash_register_stats.tt To test: - Run: $ sudo koha-shell kohadev ; cd kohaclone k$ prove xt/tt_valid.t => FAIL: Tests fail due to the mentioned templates - Apply this patch - Run: $ sudo koha-shell kohadev ; cd kohaclone k$ prove xt/tt_valid.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Passing QA directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- blocked by enhancement, passing for 16.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17635 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org