https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Should we add 'fake' records for the missing identifiers in the authority record number range at upgrade time? These should most probably be the records that have been deleted once (ignoring other technical problems, perhaps with the autoincrement of the table). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be a separate table like we have now or should we use a deleted flag on this table as it has been discussed for others? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #1)

Should we add 'fake' records for the missing identifiers in the authority record number range at upgrade time? These should most probably be the records that have been deleted once (ignoring other technical problems, perhaps with the autoincrement of the table).

I would not do that. There could be huge ranges missing due to not resetting PK during migration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165041&action=edit Bug 30888: [DBIX] Schema file for deletedauth_header Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165043&action=edit Bug 30888: Unit tests Extending DelAuthority test in AuthoritiesMarc.t. Adding Koha/Authority.t for new method move_to_deleted. Test plan: Run both tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20271 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #4)

(In reply to Marcel de Rooy from comment #1)

...

Should we add 'fake' records for the missing identifiers in the authority record number range at upgrade time? These should most probably be the records that have been deleted once (ignoring other technical problems, perhaps with the autoincrement of the table).

I would not do that. There could be huge ranges missing due to not resetting PK during migration.

Still thinking about filling it (optionally) with data from a table in a older backup or so? With some maint script perhaps, but not on this report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30887 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30887 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30887 [Bug 30887] Gravestone page for deleted authorities or biblios -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #11)

We had the discussion for "recalls" and decided to not stick to the current (wrong) pattern.

So I don't think this is acceptable, you need to add a new column to the existing table instead.

See recalls.completed. Also bug 19532 comment 5.

I just read: Regarding the number of critical issues we had the last few months, I do not think it is a good idea to reuse this pattern. We should not move data from one table to another but add a deleted/old flag instead. Is that a discussion? :) There is a lot of discussion on 20271. And it is open for 6 years already. That is imo not a good argument to block a simple and needed development like this one. I could understand that if you add a NEW table that you should do it as you said. But adding this burden to an EXISTING table is really something else. Adding this 'requirement' effectively kills this development. Can imagine that we could raise serious issues too when we add a flag and forget a few occurrences throughout the whole codebase where we read records from the table. If if would be a requirement, we should have community consensus about it and make it a coding guideline. Which I do not recommend. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #13) Thanks for taking a look.

So IIUC the contention is that authorities is an existing table and adding a deleted flag will cause it to be forgotten to be checked for in places => so bad bugs. VS having a separate table, which causes bad bugs.

Please explain why a separate table causes bad bugs. Some issues that we experienced in the past were related to autoincrement. And note that I deliberately removed the autoincrement here from the deleted table.

Introducing a flag will cause bugs only on that moment. (found and fixed in the next months)

Hopefully :) One could argue that having one table requires more careful coding and is therefore more error prone?

Does having a separate table causes bugs over time or will that also be on the moment of introduction? In other words, were the bugs due to the other deleted* tables always there? Or were they more recent due to other changes and it's easier to introduce bugs than with a deleted flag?

See above too. I am having the strong imnpression that the option with a flag might introduce more bugs than the current development. Touching more code etc. Some related questions: Why enforce something here that we have not been able to do in the last 6 years for a few similar tables? And what about: I opened this bug close to 2 years ago. And already mentioned the 'merging tables' discussion in my description. When I finally submit code, the whole discussion is revived. Is that fair? This small patch set is imo ready to be used but now the whole things must be designed differently? Will add yet another comment about the two scenarios from a more general perspective more or less proving that both ways have pro and cons. We cannot say here that the deleted flag-option should be better. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Marcel de Rooy from comment #14)

Please explain why a separate table causes bad bugs. Some issues that we experienced in the past were related to autoincrement.

Hm, I though bug 19532 comment 5 was about more stuff than autoincrement. Because these are indeed reliably avoidable now that it's known.

...

Introducing a flag will cause bugs only on that moment. (found and fixed in the next months)

Hopefully :) One could argue that having one table requires more careful coding and is therefore more error prone?

When doing delete flags, there should be something in the data layer to by default query only the non deleted data. Otherwise it will be hard to never forget to filter. And code everywhere will have some additional complexity to filter the data. It's a bit of code duplication in many places. Do we have all/almost all the interactions with the authorities table in the data layer? Otherwise it's not sure it's possible to deal with these issues :/

Some related questions: Why enforce something here that we have not been able to do in the last 6 years for a few similar tables?

Here, there is no tombstone table so introducing the flag is less work than doing that + removing the tombstone table. Still more work than for a totally new table like recalls. But before that, the question is, should we even avoid introducing a tombstone table? That's suddenly not as clear.

Will add yet another comment about the two scenarios from a more general perspective more or less proving that both ways have pro and cons. [...] Please read this on dba.stackexchange.com: https://dba.stackexchange.com/questions/14402/tombstone-table-vs-deleted- flag-in-database-syncronization-soft-delete-scenari/14419

From the discussions and attempts to switch to delete flags in the last years, it seemed a given that a tombstone table was an anti-pattern but it turns out totally not 😱

Back to trying to find the contention point: Now that it's known how to avoid autoincrement issues with tombstone tables, do they have a significant drawback for our use case? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #17)

I'm interested in the discussions here and want to help this one move forward.. I've had it added to the next dev meeting at a topic. I'm feeling out of date and knowledge at this point so don't want to push either way until we have that discussion.

Great, thanks. Confident that we will decide the right thing, lol -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #19)

We discussed this topic at the Developer's meeting on November 11:

https://koha-hedgedoc.servers.llownd.net/ Development_IRC_meeting_11_September_2024?#

This has been decided long after this development was submitted. The report was open from 2022 but nobody cared. So I do not agree. Are the people who 'decided this' also willing to refactor along the lines of the new approach? I just fear that we wont see anything moving here soon.. Closing this report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So I stayed pretty quiet in the developer meeting around this topic to be honest. I still don't feel hugely knowledgable about the topic now, but my general feeling has changed over the years around this sort of topic. Whilst I can see the advantages of a single table, I can also see the advantages of tombstone tables.. and in fact I think they both have their place in Koha. My feeling was that we agreed that generally we'd push for combined tables for Koha whenever appropriate, but I don't think we should rule out tombstones when they make sense for performance and code simplicity reasons. In this particular case, I'd actually push for the pragmatic solution of taking the code that's written. It follows some solid patterns we already have whilst also being reasonably modern in it's approach. Personally, I'd prefer to see this move and be accepted rather than have it die. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Just one sentence because unrelated to the bug: the code is in place to produce plain-text minutes as well, they just need to be uploaded to minutes.koha-community.org somehow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171850&action=edit Bug 30888: add `heading` column after bug 30047 added it to auth_header -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- "heading" column added manual deletion and merge works :D but merge test fails /kohadevbox/koha/t/db_dependent/AuthoritiesMarc.t .. 6/13 # Failed test 'Moved to deleted' # at /kohadevbox/koha/t/db_dependent/AuthoritiesMarc.t line 335. # got: undef # expected: anything else # Looks like you planned 2 tests but ran 3. # Looks like you failed 1 test of 3 run. # Failed test 'ModAuthority() tests' # at /kohadevbox/koha/t/db_dependent/AuthoritiesMarc.t line 338. # Looks like you planned 3 tests but ran 2. I don't know if creating authorities is different now with the "heading" column and it would be missing in the calls. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- There was no real discussion during the dev meeting tbh. The situation is still not clear for future improvements/new patches. It seems that we are ok to let this go as it, because the code is there already and that the auth is closed (in regard of the code and DB structure) to bib/item. They which will certainly never be merged as bug 20271 is abandoned, and accepting more like this is moving even more into that direction. I am only trying to reflect the few things what have been said during the meeting, not taking any positions here. A decision should still be taken for new tables IMO, and a coding guideline written down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #30)

"heading" column added

manual deletion and merge works :D

but merge test fails

/kohadevbox/koha/t/db_dependent/AuthoritiesMarc.t .. 6/13 # Failed test 'Moved to deleted' # at /kohadevbox/koha/t/db_dependent/AuthoritiesMarc.t line 335. # got: undef # expected: anything else # Looks like you planned 2 tests but ran 3. # Looks like you failed 1 test of 3 run.

# Failed test 'ModAuthority() tests' # at /kohadevbox/koha/t/db_dependent/AuthoritiesMarc.t line 338. # Looks like you planned 3 tests but ran 2.

I don't know if creating authorities is different now with the "heading" column and it would be missing in the calls.

Not sure what happened here. But looks like the test in Delete got moved into Mod. Maybe rebase issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165040|0 |1 is obsolete| | Attachment #165042|0 |1 is obsolete| | Attachment #165043|0 |1 is obsolete| | Attachment #171850|0 |1 is obsolete| | Attachment #171851|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172090&action=edit Bug 30888: Db rev for new table deletedauth_header In line with the other deleted tables. (See also bug 20271.) Note: Removed the auto_increment for this deleted table. There is no need for it and it could only mess up the table. Additionally, removed the index on origin. Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172092&action=edit Bug 30888: [DBIX] Schema file for deletedauth_header Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172094&action=edit Bug 30888: Unit tests Extending DelAuthority test in AuthoritiesMarc.t. Adding Koha/Authority.t for new method move_to_deleted. Test plan: Run both tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172090|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172095&action=edit Bug 30888: Db rev for new table deletedauth_header In line with the other deleted tables. (See also bug 20271.) Note: Removed the auto_increment for this deleted table. There is no need for it and it could only mess up the table. Additionally, removed the index on origin. Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172092|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172097&action=edit Bug 30888: [DBIX] Schema file for deletedauth_header Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172094|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172099&action=edit Bug 30888: Unit tests Extending DelAuthority test in AuthoritiesMarc.t. Adding Koha/Authority.t for new method move_to_deleted. Test plan: Run both tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #45)

Back to NSO. Victor, could you confirm the tests pass now and your SO ? Thanks!

s/your SO/add your SO/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172095|0 |1 is obsolete| | --- Comment #48 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172549&action=edit Bug 30888: Db rev for new table deletedauth_header In line with the other deleted tables. (See also bug 20271.) Note: Removed the auto_increment for this deleted table. There is no need for it and it could only mess up the table. Additionally, removed the index on origin. Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172097|0 |1 is obsolete| | --- Comment #50 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172551&action=edit Bug 30888: [DBIX] Schema file for deletedauth_header Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172099|0 |1 is obsolete| | --- Comment #52 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172553&action=edit Bug 30888: Unit tests Extending DelAuthority test in AuthoritiesMarc.t. Adding Koha/Authority.t for new method move_to_deleted. Test plan: Run both tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #53)

Thanks for the fix Marcel.

It works! :)

Great! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172550|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176638&action=edit Bug 30888: add `heading` column after bug 30047 added it to auth_header Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172552|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176640&action=edit Bug 30888: Copy info to deleted table Test plan: Delete an authority from the interface. Check presence in the table deletedauth_header, verify that the correct authid and authtype have been inserted. Bonus: Check leader position 05 in deleted table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26684 --- Comment #61 from Janusz Kaczmarek <januszop@gmail.com> --- Attention: we have a parallel old bug 26684, currently also in the state Passed QA, changing the structure of auth_header table --- by removing marc column. After applying both of them there will be an inconsistency in data. We should take it take into account and react appropriately. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26884 --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #62)

(In reply to Janusz Kaczmarek from comment #61)

...

Attention: we have a parallel old bug 26684, currently also in the state Passed QA, changing the structure of auth_header table --- by removing marc column. After applying both of them there will be an inconsistency in data. We should take it take into account and react appropriately.

Good point. Depends on the order chosen by the RM.

I am pondering. It might make more sense to remove the column first and then add the deletedauthorities table, so we don't add and then immediately drop the column. Would one of you be OK providing the follow-up? You can leave out the DBIC patch, just need a follow-up for the kohastructure.sql and database update. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 [Bug 26884] [Omnibus] Refactor overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #64 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #63)

(In reply to Marcel de Rooy from comment #62)

...

(In reply to Janusz Kaczmarek from comment #61)

...

Attention: we have a parallel old bug 26684, currently also in the state Passed QA, changing the structure of auth_header table --- by removing marc column. After applying both of them there will be an inconsistency in data. We should take it take into account and react appropriately.

Good point. Depends on the order chosen by the RM.

I am pondering.

It might make more sense to remove the column first and then add the deletedauthorities table, so we don't add and then immediately drop the column.

Would one of you be OK providing the follow-up? You can leave out the DBIC patch, just need a follow-up for the kohastructure.sql and database update.

I will rebase this one. Please push the other one first. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176637|0 |1 is obsolete| | --- Comment #66 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178286&action=edit Bug 30888: Db rev for new table deletedauth_header In line with the other deleted tables. (See also bug 20271.) Note: Removed the auto_increment for this deleted table. There is no need for it and it could only mess up the table. Additionally, removed the index on origin. Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> [EDIT] Removed column 'marc' (BZ 26684) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176640|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178288&action=edit Bug 30888: Copy info to deleted table Test plan: Delete an authority from the interface. Check presence in the table deletedauth_header, verify that the correct authid and authtype have been inserted. Bonus: Check leader position 05 in deleted table. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176639|0 |1 is obsolete| | --- Comment #70 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178290&action=edit Bug 30888: [DBIx] Schema changes for DeletedauthHeader.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #73)

We have a failing test that points here:

t/db_dependent/TestBuilder.t .. 1/16 # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 91. # got: '1' # expected: '0' # The following sources have not been generated correctly: DeletedauthHeader # Looks like you failed 1 test of 1. t/db_dependent/TestBuilder.t .. 3/16 # Failed test 'Build all sources' # at t/db_dependent/TestBuilder.t line 99.

Can you please have a look?

There are also fails probably stemming from bug 38689. I'll put a note there too, but maybe you can communicate about the fix.

Fails from 38689 have been fixed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #75)

Will have a look.

Pushing Martin's follow-up for the other file in a few moments. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | --- Comment #78 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked for main, thanks Marcel. Waiting to push a little, waiting for feedback on failing Jenkins nodes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not pushing yet, waiting for feedback. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- OK, existing pattern. Pushing to main with next batch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 --- Comment #84 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181913&action=edit Bug 30888: Remove KEY origincode koha-dump removes it -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Text to go in the| |This adds a new database release notes| |table deletedauthorities | |that will keep the data of | |deleted authority records, | |similar to | |deletedbiblio_metadata and | |other related tables. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42304 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42304 [Bug 42304] Add deletedauthorities to cleanup_database.pl -- You are receiving this mail because: You are watching all bug changes.