[Bug 35590] New: Add the translation of seasonal predictions for a chosen locale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Bug ID: 35590 Summary: Add the translation of seasonal predictions for a chosen locale Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: emily-rose.francoeur@inLibro.com QA Contact: testopia@bugs.koha-community.org In “Manage Numbering Pattern” (in Serials), we have the possibility to test a pattern with a specified locale. This works well for days and months (as their translations are handled by DateTime()), but it doesn't work for seasons and their abbreviations. To reproduce the bug: **I recommend using the "English" version of the staff interface, as the translation for the prediction pattern with the staff interface locale doesn't work well (see issues 20511 and 24172).** 1) Navigate to “Serials > Manage numbering patterns” and click on the “Edit” button for the “Seasonal” pattern. 2) Under “Test prediction pattern”: - Set “First issue publication date” to today's date. - Set “Subscription length” to “issues” and input “4”. - Choose a language different from the one used in the staff interface for “Locale” (so any language except English). - Set “Begins with” to 0 (for X) and 2023 (for Y). 3) Click on the “Test pattern” button. - Observe that the season names are still displayed in English. 4) In the first section of the page, within the table, change “Formatting” to “Name of season (abbreviated)”. 5) Click on the “Test pattern” button. - Observe that the season names are still displayed in English. 6) Navigate to a record detail page and click on "+ New" and then "New subscription". 7) Click on the “Next ->” button and then “OK”. 8) Fill in the following fields: - Set “First issue publication date” to today's date. - Set “Frequency” to your preference. - Set “Subscription length” to “issues” and input “4”. - Set “Subscription start date” to today's date. - Select “Seasonal” for “Numbering pattern”. - Choose a language different from the one used in the staff interface for “Locale” (so any language except English). - Set “Begins with” to 0 (for Season) and 2023 (for Year). 9) Click on the “Test pattern” button. - Observe that the season names are still displayed in English. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20511 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24172 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 --- Comment #1 from Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 159981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159981&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to “Serials > Manage numbering patterns” and click on the “Edit” button for the “Seasonal” pattern. 3) Under “Test prediction pattern”: - Set “First issue publication date” to today's date. - Set “Subscription length” to “issues” and input “4”. - Choose the language you previously installed for “Locale” (in my case, it's “Français (French)”). - Set “Begins with” to 0 (for X) and 2023 (for Y). 4) Click on the “Test pattern” button. - Observe that the season names are displayed in the other language (“Printemps Été Automne Hiver” for me). 5) In the first section of the page, within the table, change “Formatting” to “Name of season (abbreviated).” 6) Click on the “Test pattern” button. - Observe that the season abbreviated names are displayed in the other language (“Pri Été Aut Hiv” for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the “Next ->” button and then “OK”. 9) Fill in the following fields: - Set “First issue publication date” to today's date. - Set “Frequency” to your preference. - Set “Subscription length” to “issues” and input “4”. - Set “Subscription start date” to today's date. - Select “Seasonal” for “Numbering pattern”. - Choose a language different from the one used in the staff interface for “Locale” (any language except English). - Set “Begins with” to 0 (for Season) and 2023 (for Year). 10) Click on the “Test pattern” button. - Observe that the season names are displayed in the other language (“Printemps Été Automne Hiver” for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159981|0 |1 is obsolete| | --- Comment #2 from Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 159982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159982&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily-rose.francoeur@inLibr | |o.com Assignee|koha-bugs@lists.koha-commun |emily-rose.francoeur@inLibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159982|0 |1 is obsolete| | --- Comment #3 from Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 160003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160003&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160003|0 |1 is obsolete| | --- Comment #4 from Emily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 160004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160004&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160004|0 |1 is obsolete| | --- Comment #5 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161272&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t Signed-off-by: Sheila <s.abouhabib@ifporient.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Sheila <s.abouhabib@ifporient.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |s.abouhabib@ifporient.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Alexandre Noel <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Alexandre Noel <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161272|0 |1 is obsolete| | --- Comment #6 from Alexandre Noel <alexandre.noel@inlibro.com> --- Created attachment 169441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169441&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Alexandre Noel <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169441|0 |1 is obsolete| | --- Comment #7 from Alexandre Noel <alexandre.noel@inlibro.com> --- Created attachment 170119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170119&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170119|0 |1 is obsolete| | --- Comment #8 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 171032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171032&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 pjouve <pauline.jouve@enssib.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pauline.jouve@enssib.fr Status|Needs Signoff |Signed Off --- Comment #9 from pjouve <pauline.jouve@enssib.fr> --- During the 2025 Hackathon KohaLA, we tested this patch. It works well in every part of the test plan (1-10). We're from three different french libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Sophie Wawrzyniak <sophie.wawrzyniak@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.wawrzyniak@univ-lyon | |3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Melanie Catt <melanie.catt@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melanie.catt@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 --- Comment #10 from pjouve <pauline.jouve@enssib.fr> --- Created attachment 176562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176562&action=edit Screenshot of the patch's result Hello, from Hackathon KohaLA France 2025, I join here a screenshot, which shows the result of the patch on the serials planning. We can see that locale language chosen matches the season language in Prediction Pattern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 --- Comment #11 from pjouve <pauline.jouve@enssib.fr> --- Created attachment 176563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176563&action=edit Warning about limits of the patch test However, we see that the patch seems to work. During the Hackathon we want to go further and we try to receive issues. And the results weren't what we expected. As we can see on the screenshot in the column ‘Number’ we only have the year, the season doesn't appear. We want to warn about the eventuality of the patch could not work well with serials reception. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Failed QA --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Unless the above is out of scope of this patch, it looks like an issue. At least it needs to be clarified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |william.lavoie@inLibro.com --- Comment #13 from William Lavoie <william.lavoie@inLibro.com> --- I was able to reproduce the issue by creating a subscription with - Subscription length: issues 4 - Numbering pattern: Seasonal - Begins with: Winter (Season) 2025 (Year) You can put anything in the other fields. Test prediction patterns displays "number" with both the season and the year, however "serial collection" then shows only the year. Without applying the patch, this works correctly so it seems that the patch introduces this problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171032|0 |1 is obsolete| | --- Comment #14 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 179836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179836&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171032|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171032|0 |1 is obsolete| | --- Comment #15 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 179880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179880&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 --- Comment #16 from William Lavoie <william.lavoie@inLibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 --- Comment #17 from William Lavoie <william.lavoie@inLibro.com> --- It seems to me like the problem is that with the patch applied, the value inserted into the database for the column serialseq in the table serial is just the year, whereas before applying the patch it is the season and the year. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179880|0 |1 is obsolete| | --- Comment #18 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 180666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180666&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com --- Comment #19 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Cleaned the patch of random formatting that isn't part of the fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180666|0 |1 is obsolete| | --- Comment #20 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 180683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180683&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 --- Comment #21 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 180684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180684&action=edit Bug 35590: Fix issue number with season and remove unnecessary code I also removed one of the tests because we can no longer enter arbitrary string as language code to use as part of translation file name. Test plan remains the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180683|0 |1 is obsolete| | --- Comment #22 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180980&action=edit Bug 35590: Translate the seasons when testing the numbering pattern with a selected locale This patch allows you to test a numbering pattern that uses seasons or their abbreviations with the locale of your choice. Since DateTime() cannot handle translations for seasons, the patch relies on the translations in the .po files. Therefore, you need to have the .po file installed if you want to test this patch. TEST PLAN Prequisites: Install the .po files for at least one language other than the one used in your staff interface (these files should be added to the misc/translator/po/ folder). Ensure that translations for seasons (Spring, Summer, Fall, and Winter) and their abbreviations (Spr, Sum, Fal, and Win) exist (these should be in the *-staff-prog.po). In my case, I use the .po files for French Canadian translations (fr-CA) because the translations for seasons and their abbreviations already exist. 1) Apply the patch. 2) Navigate to "Serials > Manage numbering patterns" and click on the "Edit" button for the "Seasonal" pattern. 3) Under "Test prediction pattern": - Set "First issue publication date" to today's date. - Set "Subscription length" to "issues" and input "4". - Choose the language you previously installed for "Locale" (in my case, it's "Français (French)"). - Set "Begins with" to 0 (for X) and 2023 (for Y). 4) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 5) In the first section of the page, within the table, change "Formatting" to "Name of season (abbreviated)". 6) Click on the "Test pattern" button. - Observe that the season abbreviated names are displayed in the other language ("Pri Été Aut Hiv" for me). 7) Navigate to a record detail page and click on "+ New" and then "New subscription". 8) Click on the "Next ->" button and then "OK". 9) Fill in the following fields: - Set "First issue publication date" to today's date. - Set "Frequency" to your preference. - Set "Subscription length" to "issues" and input "4". - Set "Subscription start date" to today's date. - Select "Seasonal" for "Numbering pattern". - Choose a language different from the one used in the staff interface for "Locale" (any language except English). - Set "Begins with" to 0 (for Season) and 2023 (for Year). 10) Click on the "Test pattern" button. - Observe that the season names are displayed in the other language ("Printemps Été Automne Hiver" for me). 11) Run the unit tests for Serials and GetNextSeq - prove ./t/db_dependent/Serials.t - prove ./t/db_dependent/Serials/GetNextSeq.t Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180684|0 |1 is obsolete| | --- Comment #23 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180981&action=edit Bug 35590: Fix issue number with season and remove unnecessary code I also removed one of the tests because we can no longer enter arbitrary string as language code to use as part of translation file name. Test plan remains the same Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com Status|Needs Signoff |Signed Off --- Comment #24 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, here are the messages displayed after running the unit tests for Serials and GetNextSeq (I don't know if it's useful as all tests are successful) : Kohadev-koha@kohadevbox:koha(main)$ prove ./t/db_dependent/Serials.t ./t/db_dependent/Serials.t .. ok All tests successful. Files=1, Tests=64, 71 wallclock secs ( 0.06 usr 0.02 sys + 68.44 cusr 0.98 csys = 69.50 CPU) Result: PASS kohadev-koha@kohadevbox:koha(main)$ prove ./t/db_dependent/Serials/GetNextSeq.t ./t/db_dependent/Serials/GetNextSeq.t .. ok All tests successful. Files=1, Tests=33, 3 wallclock secs ( 0.04 usr 0.01 sys + 3.09 cusr 0.32 csys = 3.46 CPU) Result: PASS Manu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|emily-rose.francoeur@inLibr |shi-yao.wang@inLibro.com |o.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice@biblibre.com --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- I think there are blocking issues with this patchset: - there is no 1:1 mapping between the languages in the dropdown list and the languages in PO files, meaning Koha has to search for corresponding PO files, can found multiple matching files, and uses only the first one. For instance, fr-FR-staff-prog.po will never be used because fr-CA-staff-prog.po comes first. - it assumes that there are translations for seasons in the PO files, but if this patch is accepted, having literal names for seasons in templates will become useless, and will eventually be removed, disappearing from PO files automatically. At the very least, seasons names in C4/Serials.pm should be wrapped inside N__() from Koha::I18N. This function is a no-op but it will ensure these strings will be added to PO files (in that case they will be added to the *-messages.po files, not *-staff-prog.po) and we can search for an exact match (and not the "%s$word%s" regex) - it duplicates some code from Koha::I18N, and in fact Koha::I18N can be used to replace a lot of code from this patch, under two conditions: - We need a 1:1 mapping between the language dropdown and PO files - Users will need to have installed (misc/translator/translate install) the languages to use them (because Koha::I18N needs the .mo files). Languages won't need to be enabled in the interface. With Koha::I18N it would look like this: Koha::I18N::set_language($locale); @seasons = (__('Summer'), __('Fall'), ...); Koha::I18N::reset_language(); set_language and reset_language needs to be implemented but basically they will only have to set $ENV{LANGUAGE} (No matter which of __ or N__ is used, it might be a good idea to use the 'p' variant to add some context, because words like "Win" can be ambiguous to translators) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org