http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9628&action=edit Bug 8112 - Overdues with Fines giving duplicates If a borrower has multiple fines of type FU for a given item, that row will appear in the Overdues with Fines report for each fine on record. Fixed by grouping the results by borrowernumber. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Kyle, What is a fine of type FU ? The only occurrence I find into the code is in the routine C4::Overdues::UpdateFine. It contains 7 FIXME and it is not easy at all to understand what it does :-/ How can I add this type of fine ? Perhaps can you add a test plan for this patch please ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- GROUP BY borrowernumber will show only 1 entry by borrowernumber, even if he has fines on several items. Is this what we want? I would suggest to GROUP BY borrowers.borrowernumber, items.itemnumber -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11578&action=edit Bug 8112 - Overdues with Fines giving duplicates - Followup - Add items.itemnumber to GROUP BY -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9628|0 |1 is obsolete| | --- Comment #6 from wajasu <matted-34813@mypacks.net> --- Created attachment 11813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11813&action=edit 0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli This patch deals with fixing the overdues with fines report only. Handling of reconciling those dups must be addressed somewhere else. I only tested the behavior of the report with the above two patches. Test: 1) configured a patron with overdue items with fines. 2) i ran the overdue with fines report i saw two rows, one for each patron ( normal scenario) 3) to emulate a dupe FU fine update in accountlines, I insert the row refer to attachment above ... circulation_overdues_report_createdupefine_same_item.png for mysql work 4) i ran the overdue with fines report I saw three rows, but two for the same patron and same item (multiple FU case) refer to attachment above ... circulation_overdues_report_dupefine.png 5) applied 0001 and 0002 patches, and ran report gain I saw only two rows, even tough dups exist in the database. refer to circulation_overdues_report_dupefine1_nodupeshowing.png This reports behaviour will work wether dups exist or not. But when in place, it hides the dups. Note: Folks on IRC mentioned this was the result of an upgrade from 3.6.x to 3.8.x In leiu of performing an upgrade, I took this route. wajasu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 --- Comment #8 from wajasu <matted-34813@mypacks.net> --- Created attachment 11815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11815&action=edit circulation_overdues_report_dupefine.png -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11816|0 |1 is obsolete| | --- Comment #10 from wajasu <matted-34813@mypacks.net> --- Created attachment 11817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11817&action=edit circulation_overdues_report_createdupefine_same_item.png -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813@mypacks.net -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Summary|Overdues with Fines giving |Overdues with Fines report, |duplicates |giving duplicates --- Comment #13 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)

Created attachment 11813 [details] 0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli

This patch deals with fixing the overdues with fines report only.

Handling of reconciling those dups must be addressed somewhere else.

I only tested the behavior of the report with the above two patches.

Test: 1) configured a patron with overdue items with fines. 2) i ran the overdue with fines report i saw two rows, one for each patron ( normal scenario) 3) to emulate a dupe FU fine update in accountlines, I insert the row refer to attachment above ... circulation_overdues_report_createdupefine_same_item.png for mysql work 4) i ran the overdue with fines report I saw three rows, but two for the same patron and same item (multiple FU case) refer to attachment above ... circulation_overdues_report_dupefine.png 5) applied 0001 and 0002 patches, and ran report gain I saw only two rows, even tough dups exist in the database. refer to circulation_overdues_report_dupefine1_nodupeshowing.png

This reports behaviour will work wether dups exist or not. But when in place, it hides the dups.

Note: Folks on IRC mentioned this was the result of an upgrade from 3.6.x to 3.8.x In leiu of performing an upgrade, I took this route.

wajasu

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #15 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #12)

Is it normal the followup changes only 1 query ? I think the problem exists in the 2 cases. But I have not tested !

oops, i missed Jonathans comment Kyle, any response for only the 1 query change, not 2? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12309&action=edit Bug 8112 - Overdues with Fines dup Followup 2 - Add items.itemnumber to GROUP BY when using $location -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #18 from wajasu <matted-34813@mypacks.net> --- After signing off bug 8253 (for 3.8.x and suggesting it be applied to master as well), I realized that this older patch is an earlier bandaid for duplicate fines at the reporting level. As long as 8253 gets applied to master, this report fix is obsolete. So after talking with Kyle, we are marking it as a duplicate of 8253. wajasu *** This bug has been marked as a duplicate of bug 8253 *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |koha@univ-lyon3.fr Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.