[Bug 40430] New: Toolbar_spec.ts is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Bug ID: 40430 Summary: Toolbar_spec.ts is failing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org It's failing on Jenkins because there is no vendor in the DB. 00:54:30 koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'Receive shipment from vendor My Vendor' within the element: <h1> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Receive shipment from vendor My Vendor' within the element: <h1> but never did. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 [Bug 40067] "Receive shipments" should not open in a new tab/window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- So, here we are. Jenkins is failing on a Cypress test (Toolbar_spec.ts) because it relies on data that is not in the DB: vendor #1 is injected by misc4dev and is not part of the sample data. Which means the test passes locally but fails on Jenkins. To fix this, I need the work I have been working on for the last weeks. Now it's either we have it and I can fix the tests correctly (creating the vendor in DB), or we drop the test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 [Bug 40318] "Receive shipments" should not open in a new tab/window - vendor list view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 [Bug 40345] Missing Cypress tests for checkout history - OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40433 [Bug 40433] Missing maxLength in item, patron and library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184196&action=edit Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Acquisitions/Vendors_spec.ts pass, even if you do not have any vendors in DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184196|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184197&action=edit Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Acquisitions/Vendors_spec.ts pass, even if you do not have any vendors in DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184197|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184198&action=edit Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184198|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184238&action=edit Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184238|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184350&action=edit Bug 40430: Fix Toolbar_spec.ts See comment 1 on the bug. We are adding the capability to insert vendors and baskets. Test plan: Confirm that yarn cypress run t/cypress/integration/Toolbar_spec.ts pass, even if you do not have any vendors in DB. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Bug 40430 depends on bug 40067, which changed state. Bug 40067 Summary: "Receive shipments" should not open in a new tab/window https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dependencies not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Bug 40430 depends on bug 40433, which changed state. Bug 40433 Summary: Missing maxLength in item, patron and library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40433 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 Bug 40430 depends on bug 40345, which changed state. Bug 40345 Summary: Missing Cypress tests for checkout history - OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40345 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #10 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org