[Bug 9410] New: Formatting of the discount field when doing a new order from new empty record is not correct
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Bug ID: 9410 Summary: Formatting of the discount field when doing a new order from new empty record is not correct Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: hugh@davenport.net.nz Discount shows 4 decimal places, it should show 1 like other places that show discount rate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #1 from Hugh Davenport <hugh@davenport.net.nz> --- Created attachment 14645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14645&action=edit bug 9410 Fix formatting of discount rate The formatting for discount doesn't limit the number of decimal points for the discount rate when creating a new order from an empty record. This patch fixes that by limiting it to 2dp Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hugh@davenport.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14645|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15354&action=edit bug 9410 Fix formatting of discount rate The formatting for discount doesn't limit the number of decimal points for the discount rate when creating a new order from an empty record. This patch fixes that by limiting it to 2dp Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- The aqorders.discount field is a float(6,4) in DB. If we limit the value to 2 in the interface, we should limit the number of decimals in the DB structure too. However, maybe the 4 decimals are used by some library (hum... it should be surprising). Switch to in discussion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- I just seen you already submitted a patch for the supplier form (bug 9062). You limited the discount value to 1 decimal, we have to be consistent. 2 is certainly the best choice, but in this case a patch for the supplier form is required (and maybe for DB changes). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #5 from Hugh Davenport <hugh@davenport.net.nz> --- Hi Jonathan, I would agree, prehaps we should make another bug for changing the patch made in bug 9062 to use 2dp as well, and push this one through as is, as long as everyone is happy with that. Cheers, Hugh -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Ok, switch back to Signed Off and let someone else qa this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, there is some inconsistency in how we format tax and discount in various places in Koha: Tax: Available tax values are controlled by system preference gist. It's possible to enter values <1% there but the display shows max 2dp%. Example: gist: 0.066, display when selecting: 0.7%, display in order summary page: 2dp. tax any gist (input field, no validation) 1dp discount 1dp Vendor - summary 1dp Vendor - edit (display of saved value) any Vendor - edit (input field, no validation) 2dp Order - order line edit/add (with patch) - Order - summary, doesn't show discount - Receive, doesn't show discount -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Accidentally submitted the form earlier, let's try that again: There is some inconsistency in how we format tax and discount in various places in Koha: Tax: Available tax values are controlled by system preference gist. It's possible to enter values <1% there but the display shows max 2dp%. Example: gist: 0.066, display in pull down: 0.7%, display in order summary page 0.66. tax any gist (input field, no validation) 1dp pull down used for add/edit/modify in vendor and order lines 1dp Order - summary, rounded 2dp Receive - summary discount 1dp Vendor - summary 1dp Vendor - edit (display of saved value) any Vendor - edit (input field, no validation) 2dp Order - order line edit/add (with patch) - Order - summary, doesn't show discount - Receive - summary, doesn't show the discount So we have some mismatch here - I am not sure right now how to solve it. Can we get some opinions on this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19792&action=edit Bug 9410: Draft: TT Plugin for formatting prices, etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19792|Bug 9410: Draft: TT Plugin |[ALT] Bug 9410: Draft: TT description|for formatting prices, etc. |Plugin for formatting | |prices, etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- I think template plugin is much more appropriate in this case. What do you think about this patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19792|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21267&action=edit [ALT] Bug 9410: Draft: TT Plugin for formatting prices, etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- What about my proposed patch? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org