[Bug 27605] New: Add floating toolbar to patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Bug ID: 27605 Summary: Add floating toolbar to patron search page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I would be useful to have a floating toolbar on the patron search results page in the patrons module so that one has access to controls for adding patrons to lists and merging patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116283&action=edit Bug 27605: Add floating toolbar to patron search page This patch modifies the patron search results page so that the toolbar with results-related controls "floats" when the user scrolls down. This gives access to the controls for adding patrons to a list and for merging patrons. Other templates are modified to incorporate a change to the CSS which changes "#searchheader" to ".searchheader," enabling multiple instances of a <div> styled with the .searchheader class. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Patrons in the staff interface. - Perform a patron search which will return many results. - Scroll down the page far enough to trigger the floating toolbar. - Confirm that the toolbar is positioned correctly when paging through results. - Confirm that the patron list and merge controls still work correctly. - Confirm that other pages which used the "#searchheader" id are still styled correctly: - Catalog search results - List contents - Patron list contents - Add orders from MARC file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116283|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116289&action=edit Bug 27605: Add floating toolbar to patron search page This patch modifies the patron search results page so that the toolbar with results-related controls "floats" when the user scrolls down. This gives access to the controls for adding patrons to a list and for merging patrons. Other templates are modified to incorporate a change to the CSS which changes "#searchheader" to ".searchheader," enabling multiple instances of a <div> styled with the .searchheader class. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Patrons in the staff interface. - Perform a patron search which will return many results. - Scroll down the page far enough to trigger the floating toolbar. - Confirm that the toolbar is positioned correctly when paging through results. - Confirm that the patron list and merge controls still work correctly. - Confirm that other pages which used the "#searchheader" id are still styled correctly: - Catalog search results - List contents - Patron list contents - Add orders from MARC file Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116289|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116446&action=edit Bug 27605: Add floating toolbar to patron search page This patch modifies the patron search results page so that the toolbar with results-related controls "floats" when the user scrolls down. This gives access to the controls for adding patrons to a list and for merging patrons. Other templates are modified to incorporate a change to the CSS which changes "#searchheader" to ".searchheader," enabling multiple instances of a <div> styled with the .searchheader class. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Patrons in the staff interface. - Perform a patron search which will return many results. - Scroll down the page far enough to trigger the floating toolbar. - Confirm that the toolbar is positioned correctly when paging through results. - Confirm that the patron list and merge controls still work correctly. - Confirm that other pages which used the "#searchheader" id are still styled correctly: - Catalog search results - List contents - Patron list contents - Add orders from MARC file Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was a little surprised that the "second" toolbar was the floating one, not the one with "Patron lists" and "New patron". But the ones floating make more sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not work with bug 27403 applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 [Bug 27403] Enable fixedHeader for Datatables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've marked this one dependent, can it be fixed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116528&action=edit Bug 27605: (follow-up) Make the feature work with Bug 27403 This patch adds the "fh-fixedHeader" class to the floating toolbar so that the floating DataTable header knows what element to append itself to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch modifies the release notes| |patron module's search | |interface so that the | |toolbar of results-related | |controls sticks to the top | |of the screen as the user | |scrolls down. This | |gives | |access to the controls for | |adding patrons to a list | |and for merging patrons. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not blocker, just noting: there is a very small shift (right/left): https://snipboard.io/LuA9Td.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org