[Bug 32817] New: Fix cataloguing/value_builder/dateaccessioned.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Bug ID: 32817 Summary: Fix cataloguing/value_builder/dateaccessioned.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 146075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146075&action=edit Bug 32817: Fix cataloguing/value_builder/dateaccessioned.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- When I add the plugin to a 952 field like 'Date acquired' and then go to an item record, when I like on the '...' the page jumps back to the top. This doesn't happen without the patch. This appears to happen for me in both Chrome and Firefox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- We can stop the links for jumping by using "#/" instead of "#" as the href. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146175&action=edit Bug 32817: Stop links from jumping to top of page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Ah, sorry... The call to preventDefault should be removed after bug 30975 is pushed. I'll fix the dependency order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30975 Blocks|30975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Julian Maurice from comment #5)
Ah, sorry... The call to preventDefault should be removed after bug 30975 is pushed. I'll fix the dependency order
Ah I see, thanks! It looks like the dependency order for most the bugs linked to Bug 30975 need changed as well, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Lucas Gass from comment #6)
Ah I see, thanks! It looks like the dependency order for most the bugs linked to Bug 30975 need changed as well, right? No, most of them are really required for bug 30975. This one was only an unnecessary cleanup (bug 30975 adds the call to event.preventDefault outside of the plugin code). There might be others, i will check them all.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Clean up |cataloguing/value_builder/d |cataloguing/value_builder/d |ateaccessioned.pl |ateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146075|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 148846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148846&action=edit Bug 32817: Fix cataloguing/value_builder/dateaccessioned.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- How I tested ~~~~~~~~~~~~ 1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs. 2. The plugin dateaccessioned.pl is already added in KTD to: 2.1 subfield 995$5 for the default UNIMARC bibliographic framework (need to edit to make visible in the editor) 2.1 subfield 952$d for the BKS MARC21 bibliographic framework (already visible in the editor) 3. Edit a bibliographic record. 4. Select the tag editor for the subfield. 5. Options and values should be the same before and after the patch is applied. Description ~~~~~~~~~~~ This is a standard cataloguing plugin. It displays the flatpickr date widget to let you select the date an item was acquired (995$5 in UNIMARC and 952$d in MARC21). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30975 Depends on|30975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148846|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150096&action=edit Bug 32817: Fix cataloguing/value_builder/dateaccessioned.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #12 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org