[Bug 39757] New: Serial enumeration / chronology sorting is broken again in biblio page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Bug ID: 39757 Summary: Serial enumeration / chronology sorting is broken again in biblio page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In biblio page, subscription sorting is broken again :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you explain a bit more? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181577&action=edit Bug 39757: Fix default sort order Test plan: 1 - Have a notice with mutliple serials received on different days, notice they are not sorted by date by default 2 - Have a non-serial notice, notice there is no sort order 3 - Apply patch 4 - Go to the serials notice -> it is well ordered (by acquisition date) 5 - Go to the non-serial notice -> is is sorted by accession date Note: I picked accession date because it is how it works in Koha::Item::search_ordered which is not used anymore for this purpose. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28171 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Is this related to this FIXME in Koha/REST/V1/Biblios.pm + # FIXME We need to order_by serial.publisheddate if we have _order_by=+me.serial_issue_number Isn't it something we need server-side instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Is this related to this FIXME in Koha/REST/V1/Biblios.pm + # FIXME We need to order_by serial.publisheddate if we have _order_by=+me.serial_issue_number
Isn't it something we need server-side instead?
Hum... I'd rather say both ? If we only fix on server side, the information of the sort order won't be displayed to the user, will it ? I'd rather say the API stays simple and stupid and we sort as we want on client side, but this comment is there, you're right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- What about serialid.publisheddate vs dateaccessioned? I don't remember exactly but I would look at how it was done before bug 33568. I cannot right now, but I can have another look later. I would also ask Katrin and/or Nick. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Idk if this helps, but in Koha::Items::search_ordered, it is : serialid.publisheddate > me.enumchron for serials and homebranch.branchname > me.enumchron > me.dateaccessioned (desc) for others -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Bug 39757 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Koha::REST::V1::Biblios get_items() uses search_ordered() so why not Koha::REST::V1::Items list() ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Baptiste, trying to dig into this one, but I have some questions: - How do we recognize what you called "serial" in the test plan? - I feel like in the past the datepublished of the serial issue was used, which could make more sense as something might be acquired out of turn and the datepublished would be "closer" to sorting by serial enumeration. Maybe we could verify the old behavior first. Dateaccessioned doesn't feel quite right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've located this bug, that shows how it worked previously: Bug 28171 - Serial enumeration / chronology sorting is broken in biblio page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Serial enumeration / |Serial enumeration / |chronology sorting is |chronology sorting is |broken again in biblio page |broken again in | |bibliographic page in staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I don't understand the first point in Comment 8 =/ I totally agree with you concerning the second one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39757 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #10)
I don't understand the first point in Comment 8 =/ I totally agree with you concerning the second one
You wrote: 1 - Have a notice with mutliple serials received on different days, notice they are not sorted by date by default 2 - Have a non-serial notice, notice there is no sort order The question was: What is a serial and a non-serial notice in this description? It looks like in the past a serial was a record that is linked to a subscription, as publisheddate was used for sorting, which comes from the issue. But since your patch uses dateaccessioned from the item, I was not sure what you meant here. I know in UNIMARC there is also a serial flag on the record, but that is not used/set for MARC21. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org