https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75319&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #2 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Jonathan Druart from comment #0)

When a method is not allowed yet (not covered by tests)

Is this about automated tests? Then what does this has to do when executing the method? Is this a way to make people to write tests? It seems that there can be other causes to this error, is that correct? I also heard that this had to do with the mapping with de DB columns being done or not. So, I'm confused ^^" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- I have a (good ?) example on my test instance : when I try to use the new syspref to mark an item lost and notify patron from holds to pull list, I get this software error : The method homebranch is not covered by tests!" Applying this patch, I get this one : The method Koha::Patron->homebranch is not covered by tests! Trace begun at /var/repositories/koha/Koha/Object.pm line 398 Koha::Object::AUTOLOAD('Koha::Patron=HASH(0x8d10e08)') called at /var/repositories/koha/ circ/pendingreserves.pl line 71 Is it the behaviour you were looking for ? As I don't know what you expect I prefer not signing it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75319|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75547&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75547|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75552&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Julian Maurice from comment #3)

So, the message should probably be "This method does not exist" rather than "not covered by tests".

Any opinion on that ? Should I open a new bug ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Julian Maurice from comment #7)

(In reply to Julian Maurice from comment #3)

...

So, the message should probably be "This method does not exist" rather than "not covered by tests".

Any opinion on that ? Should I open a new bug ?

I agree. File a new one! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We need it to be backported to help debug! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I choose not to backport to 17.05.x, I focus on major and blocker -- You are receiving this mail because: You are watching all bug changes.