[Bug 21407] New: Can't enter new macros in the advanced cataloging editor (rancor)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Bug ID: 21407 Summary: Can't enter new macros in the advanced cataloging editor (rancor) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Seems to be a styling issue - if I remove 'flex' from the css using the inspector the box appears to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- It appears that a Codemirror upgrade fixes this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79382&action=edit Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) This patch upgrades Codemirror to the latest version (5.40.2). Doing so fixes a problem with the advanced cataloging editor's macro editor which appears in the latest version of Firefox (62): The first line of the macro editor is not visible. To test, apply the patch and clear your browser cache if necessary. EnableAdvancedCatalogingEditor must be set to "Enable." - Go to Cataloging -> Advanced editor. - Click the "Macros" toolbar button. - In the main part of this modal window you should see a blank line marked "1." - Click "New macro..." - The editor's line 1 should now be editable. Enter text to confirm that it works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79382|0 |1 is obsolete| | --- Comment #3 from Michal Denar <black23@gmail.com> --- Created attachment 79463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79463&action=edit Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) This patch upgrades Codemirror to the latest version (5.40.2). Doing so fixes a problem with the advanced cataloging editor's macro editor which appears in the latest version of Firefox (62): The first line of the macro editor is not visible. To test, apply the patch and clear your browser cache if necessary. EnableAdvancedCatalogingEditor must be set to "Enable." - Go to Cataloging -> Advanced editor. - Click the "Macros" toolbar button. - In the main part of this modal window you should see a blank line marked "1." - Click "New macro..." - The editor's line 1 should now be editable. Enter text to confirm that it works correctly. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79463|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79472&action=edit Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor) This patch upgrades Codemirror to the latest version (5.40.2). Doing so fixes a problem with the advanced cataloging editor's macro editor which appears in the latest version of Firefox (62): The first line of the macro editor is not visible. To test, apply the patch and clear your browser cache if necessary. EnableAdvancedCatalogingEditor must be set to "Enable." - Go to Cataloging -> Advanced editor. - Click the "Macros" toolbar button. - In the main part of this modal window you should see a blank line marked "1." - Click "New macro..." - The editor's line 1 should now be editable. Enter text to confirm that it works correctly. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate, | |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org --- Comment #8 from AspenCat Team <aspencatteam@clicweb.org> --- This is quite frustrating as it seems browser dependent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are you suggesting there's still a problem here? If that's the case can you open a new bug and describe how to replicate it including which browser it is presenting in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21407 --- Comment #10 from AspenCat Team <aspencatteam@clicweb.org> --- (In reply to Martin Renvoize from comment #9)
Are you suggesting there's still a problem here? If that's the case can you open a new bug and describe how to replicate it including which browser it is presenting in.
Sorry - The patch which fixed this is loaded to our test site, so all is good. New to the system. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org