[Bug 24583] New: Rewrite mandatory installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bug ID: 24583 Summary: Rewrite mandatory installation files to YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr A complete rewrite of mandatary instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|frederic@tamil.fr | Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 98414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98414&action=edit Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 98415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98415&action=edit Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 98416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98416&action=edit Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 98417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98417&action=edit Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 98418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98418&action=edit Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13897, 24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98414|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99397&action=edit Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98415|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99398&action=edit Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98416|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99399&action=edit Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98417|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99400&action=edit Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98418|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99401&action=edit Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work Bernardo, looks solid to me and installs fine. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13897 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 100195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100195&action=edit Bug 24583: (followup) restore null values to labels This patch adds null values to selected label2/3 in sample numberpatterns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99397|0 |1 is obsolete| | Attachment #99398|0 |1 is obsolete| | Attachment #99399|0 |1 is obsolete| | Attachment #99400|0 |1 is obsolete| | Attachment #99401|0 |1 is obsolete| | Attachment #100195|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100346&action=edit Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100347&action=edit Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100348&action=edit Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100349&action=edit Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100350&action=edit Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100351&action=edit Bug 24583: (followup) restore null values to labels This patch adds null values to selected label2/3 in sample numberpatterns Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100389&action=edit Bug 24583: adjust xt/sample_notices.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100389|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100391&action=edit Bug 24583: adjust xt/sample_notices.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #23 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org