https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133044&action=edit Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #2)

Everything works as described. I have no very minor complaint:

Before the patch there is some padding-top of the UI tabs which gives them a little bit of space after the select dropdown. ( #branchcode )

With the patch there is no padding and the select dropdown sits right on top of the tabs.

It's a very nit-picky problem and not enough to 'Fail QA' imo, so I am signing off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133044|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 133182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133182&action=edit Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133182|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133484&action=edit Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hi, With this patch, if table has no content, you see a rectangle. Looks like this comes from : + <div class="tab-content"> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #8)

Hi,

With this patch, if table has no content, you see a rectangle. Looks like this comes from : + <div class="tab-content">

This is really minor, it can be done later. Patch needs rebase please. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133484|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134611&action=edit Bug 30473: Convert suggestions page tabs to Bootstrap This patch updates the suggestions page to use Bootstrap tabs instead of jQueryUI. To test you should have multiple suggestions from different libraries, different item types, and different statuses. Apply the patch and go to Suggestions. - Suggestions should initially be displayed in tabs by status. - Confirm that the tabs look correct and work correctly. - Test that tabs work correctly for each option in the "Organize by" dropdown in the left-hand sidebar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30473 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.