[Bug 39482] New: Link to edit OpacLibraryInfo from library edit page broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Bug ID: 39482 Summary: Link to edit OpacLibraryInfo from library edit page broken Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When editing a library which has OpacLibraryInfo defined there is a link in the form "Edit HTML content". The link passes the wrong id parameter, resulting in an incorrect entry being edited. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Equally bad but more confusing, it seems to be the wrong id parameter unless the right one is currently the highest number there has ever been. When you you go to test it in ktd, you have to create an OpacLibraryInfo page, and then you see that your link has the right id, 7. Create another sort of HTML customization page, and now the link is wrongly id 9. Delete that second one, your link is still 9. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185452&action=edit Bug 39482: Correct the link to edit OpacLibraryInfo from library edit page When editing a library which has an associated OpacLibraryInfo HTML customization the "Edit HTML content" link passes the wrong id parameter. To test, apply the patch and restart services. - Rebuild OPAC CSS. - Go to Administration -> Libraries. - Edit a library. - If there is no OpacLibraryInfo customization associated with that library, add at least two OpacLibraryInfo entries and then return to the library edit form. - By the "OPAC information" label you should see all of the OpacLibraryInfo entries you added for that library. - If you have permission to edit HTML customizations you should see an edit link. - Test each to confirm that it opens the correct entry for editing. - Return to Administration -> Libraries and click the library name to view it (rather than edit). - The correct HTML customizations should appear. If you have permission to edit HTML customizations you should see corresponding "Edit" links. - Test each to confirm that it opens the correct entry for editing. - In the OPAC, locate a bibliographic record which has one or more items from the library you added OpacLibraryInfo to. - In the holdings table, click the one of the library links to trigger the info modal. - Confirm that all the correct information displays. - Go to "Libraries" link in the menu under the quick search bar. - Click the library you modified. Confirm that the correct OpacLibraryInfo entries display. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This necessitates a change to t/db_dependent/Koha/Library.t but I'm not sure how to do that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185452|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 185484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185484&action=edit Bug 39482: Correct the link to edit OpacLibraryInfo from library edit page When editing a library which has an associated OpacLibraryInfo HTML customization the "Edit HTML content" link passes the wrong id parameter. To test, apply the patch and restart services. - Rebuild OPAC CSS. - Go to Administration -> Libraries. - Edit a library. - If there is no OpacLibraryInfo customization associated with that library, add at least two OpacLibraryInfo entries and then return to the library edit form. - By the "OPAC information" label you should see all of the OpacLibraryInfo entries you added for that library. - If you have permission to edit HTML customizations you should see an edit link. - Test each to confirm that it opens the correct entry for editing. - Return to Administration -> Libraries and click the library name to view it (rather than edit). - The correct HTML customizations should appear. If you have permission to edit HTML customizations you should see corresponding "Edit" links. - Test each to confirm that it opens the correct entry for editing. - In the OPAC, locate a bibliographic record which has one or more items from the library you added OpacLibraryInfo to. - In the holdings table, click the one of the library links to trigger the info modal. - Confirm that all the correct information displays. - Go to "Libraries" link in the menu under the quick search bar. - Click the library you modified. Confirm that the correct OpacLibraryInfo entries display. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes editing and release notes| |showing OpacLibraryInfo | |HTML customizations | |information in the staff | |interface and OPAC: | | | |1. Staff interface: | | - When editing a library | |(Koha administration > | |Libraries > Actions > Edit) | | . the links to edit | |OpacLibraryInfo entries for | |the OPAC information field | |are now correct | |(previously, they may have | |linked to an incorrect HTML | |customization) | | . if there is more | |than one OpacLibraryInfo | |entry, all entries are now | |shown (only one entry was | |shown previously) | | - When viewing library | |information (Koha | |administration > Libraries | |> Name > [click library | |name]), all the | |OpacLibraryInfo entries are | |now shown | | | |2. OPAC: | | - All the entries for a | |library (including any 'All | |libraries' entries for | |OpacLibraryInfo) are now | |shown on the library | |information page (from the | |'Libraries' link under the | |quick search bar) | | - In a record's holdings | |table, the pop-up window | |when you click on the | |current library for an item | |now correctly shows all | |entries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40460 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #5 from David Nind <david@davidnind.com> --- Is Bug 40460 - Link from branch edition toward OPAC personnalisation is broken, the same a this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I was not aware of Bug 40460, but it is a duplicate. However, I think this patch is more complete because it accommodates cases where there is more than one HTML customization for one library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185484|0 |1 is obsolete| | --- Comment #7 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185561&action=edit Bug 39482: Correct the link to edit OpacLibraryInfo from library edit page When editing a library which has an associated OpacLibraryInfo HTML customization the "Edit HTML content" link passes the wrong id parameter. To test, apply the patch and restart services. - Rebuild OPAC CSS. - Go to Administration -> Libraries. - Edit a library. - If there is no OpacLibraryInfo customization associated with that library, add at least two OpacLibraryInfo entries and then return to the library edit form. - By the "OPAC information" label you should see all of the OpacLibraryInfo entries you added for that library. - If you have permission to edit HTML customizations you should see an edit link. - Test each to confirm that it opens the correct entry for editing. - Return to Administration -> Libraries and click the library name to view it (rather than edit). - The correct HTML customizations should appear. If you have permission to edit HTML customizations you should see corresponding "Edit" links. - Test each to confirm that it opens the correct entry for editing. - In the OPAC, locate a bibliographic record which has one or more items from the library you added OpacLibraryInfo to. - In the holdings table, click the one of the library links to trigger the info modal. - Confirm that all the correct information displays. - Go to "Libraries" link in the menu under the quick search bar. - Click the library you modified. Confirm that the correct OpacLibraryInfo entries display. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from David Nind <david@davidnind.com> --- *** Bug 40460 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This breaks tests: prove -v /kohadevbox/koha/t/db_dependent/Koha/Library.t # Subtest: opac_info tests 1..8 # No tests run! not ok 2 - No tests run for subtest "opac_info tests" # Failed test 'No tests run for subtest "opac_info tests"' # at /kohadevbox/koha/t/db_dependent/Koha/Library.t line 176. The method Koha::AdditionalContentsLocalizations->content is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Failed QA --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #3)
This necessitates a change to t/db_dependent/Koha/Library.t but I'm not sure how to do that!
Sorry Owen, I missed this comment before pushing. For the time being I am reverting this until we can figure out how to adjust those tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 | released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- For tests, since it is now returning a set of results instead of the best match I think we can get opac_info as a list and check the first thing returned in the array which should be the best result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #12)
For tests, since it is now returning a set of results instead of the best match I think we can get opac_info as a list and check the first thing returned in the array which should be the best result.
Or maybe not. search_for_display does not seem to return a consistent order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185674&action=edit Bug 39482: (follow-up) Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Adjusted a test but let's set it back to 'Signed-off' so someone can double check those tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185674|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189200&action=edit Bug 39482: (follow-up) Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - return Koha::AdditionalContents->find_best_match( + return Koha::AdditionalContents->search_for_display( + [% FOREACH info IN OpacLibraryInfo %] + [% IF library.branchcode == info.branchcode %] When reading this, I wonder if we should not correct the find_best_match call? It was specifically added for this case.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #17)
- return Koha::AdditionalContents->find_best_match( + return Koha::AdditionalContents->search_for_display(
+ [% FOREACH info IN OpacLibraryInfo %] + [% IF library.branchcode == info.branchcode %]
When reading this, I wonder if we should not correct the find_best_match call? It was specifically added for this case..
This does seem like find_best_match should be the call. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lisette Scheer from comment #18)
This does seem like find_best_match should be the call.
find_best_match only returns one entry, and we want to show all for that library. search_for_display seems to work for me, am I missing a problem with that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Owen Leonard from comment #19)
(In reply to Lisette Scheer from comment #18)
This does seem like find_best_match should be the call.
find_best_match only returns one entry, and we want to show all for that library. search_for_display seems to work for me, am I missing a problem with that?
Ooooh, I understand now. This is fixing the problem where it only shows one (find_best_match) instead of all. I'll work on re-qaing that this week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185561|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190693&action=edit Bug 39482: Correct the link to edit OpacLibraryInfo from library edit page When editing a library which has an associated OpacLibraryInfo HTML customization the "Edit HTML content" link passes the wrong id parameter. To test, apply the patch and restart services. - Rebuild OPAC CSS. - Go to Administration -> Libraries. - Edit a library. - If there is no OpacLibraryInfo customization associated with that library, add at least two OpacLibraryInfo entries and then return to the library edit form. - By the "OPAC information" label you should see all of the OpacLibraryInfo entries you added for that library. - If you have permission to edit HTML customizations you should see an edit link. - Test each to confirm that it opens the correct entry for editing. - Return to Administration -> Libraries and click the library name to view it (rather than edit). - The correct HTML customizations should appear. If you have permission to edit HTML customizations you should see corresponding "Edit" links. - Test each to confirm that it opens the correct entry for editing. - In the OPAC, locate a bibliographic record which has one or more items from the library you added OpacLibraryInfo to. - In the holdings table, click the one of the library links to trigger the info modal. - Confirm that all the correct information displays. - Go to "Libraries" link in the menu under the quick search bar. - Click the library you modified. Confirm that the correct OpacLibraryInfo entries display. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190694&action=edit Bug 39482: (follow-up) Adjust tests Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 --- Comment #24 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #25 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- The patch applies cleanly to 25.05, but does not behave as expected and results in breakage. I’m not planning to backport it at this time. If an updated version compatible with 25.05 becomes available, I’d be happy to review it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #26 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Liddle <david_liddle@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43697 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39482 David Liddle <david_liddle@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david_liddle@sil.org --- Comment #27 from David Liddle <david_liddle@sil.org> --- I've reported this same issue for 24.11 in Bug 43697: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43697 If it can be fixed without causing issues such as the ones mentioned here for 25.05, that would be great. Since there's a workaround, I consider it a minor issue. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org