http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15586&action=edit Proposed patch See commit comment -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I propose to disable first rewriting rule "RewriteRule (.+) $1?%1%2 [N,R,NE]" because we notices that it can cause some problems. For example, a library has defined some search links in OPACNav : "/cgi-bin/koha/opac-search.pl?idx=kw&idx=kw&idx=kw&limit=mc-ccode%3ADVD" (%3A means ":"). When clicking on this URL, it is rewritten and espaced characters are re-escaped : "mc-ccode%3ADVD" becomes "mc-ccode%253ADVD", witch is wrong. I've searched but I could not find what is the purpose of this rule. Does someone know ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #2)

Could you address what the ramifications of this change would be? Do we lose any functionality?

Setting rewrite conditional does not change anything. If we can find wat is the purpose of first rewrite rule, it will be disabled but only for new installs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- http://lists.koha-community.org/pipermail/koha-devel/2007-December/029821.ht... Considering how wrong the author of that email was about pretty much everything else, I vote for removing it (empty params are harmless, much more harmless than rewriting urls we don't need to) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15586|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16215&action=edit Bug 9683: Allow disable rewrite apache mod In Apache config koha-httpd.conf, URL-rewriting is enabled and does not allow to disable mod_rewrite. Also, first rewriting rule "RewriteRule (.+) $1?%1%2 [N,R,NE]" is enabled by default. This rule rewrites nearly every URL. I propose to comment it in sources so that is must be intentionally enabled. This patch sets rewriting options into a conditional tag. Test plan : Test OPAC and intranet with and without mod_rewrite activated. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16215|0 |1 is obsolete| | --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 17151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17151&action=edit Bug 9683: Allow disable rewrite apache mod In Apache config koha-httpd.conf, URL-rewriting is enabled and does not allow to disable mod_rewrite. Also, first rewriting rule "RewriteRule (.+) $1?%1%2 [N,R,NE]" is enabled by default. This rule rewrites nearly every URL. I propose to comment it in sources so that is must be intentionally enabled. This patch sets rewriting options into a conditional tag. Test plan : Test OPAC and intranet with and without mod_rewrite activated. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9683 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.