[Bug 5984] New: OPAC: Hide items using a config file to determine what to hide
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Bug #: 5984 Summary: OPAC: Hide items using a config file to determine what to hide Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Blocks: 5584 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC: Hide items using a |OPAC: Hide items using a |config file to determine |systempreferces to |what to hide |determine what to hide -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 02:48:46 UTC --- This needs a follow up patch to set the values in the syspref.sql file (and other language ones) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 02:50:50 UTC --- Created attachment 3491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3491 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 02:54:29 UTC --- Created attachment 3492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3492 Followup patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-29 03:02:23 UTC --- Created attachment 3493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3493 Another follow up -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-03-29 11:59:58 UTC --- I'm not seeing the *.pref file edited in any of these patches which means no one can set the preference. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com --- Comment #6 from Jane Wagner <jwagner@ptfs.com> 2011-03-29 12:19:16 UTC --- What is the purpose of this feature? Is it to hide all items except those belonging to the patron's branch? I've tried reading the patch files but I'm not clear on it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #7 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-04 13:35:03 UTC --- The purpose of this feature is to give the ability to define custom rules to hide items. The rules are based on the items table fields. The user can define values that makes the item hidden. If at least one of the defined rules match, the item is hidden. Some examples can ben found here : docs/opac/OpacHiddenItems.txt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #8 from Jane Wagner <jwagner@ptfs.com> 2011-04-04 14:35:24 UTC --- I just updated my current head server, but I do not see a docs/opac/OpacHiddenItems.txt file. The only thing under docs is history.txt. Can you attach this file to the bugzilla entry? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |--- --- Comment #9 from Magnus Enger <magnus@enger.priv.no> 2011-04-04 15:19:21 UTC --- Two problems, already mentioned: 1. OpacHiddenItems is not added to any .pref file 2. OpacHiddenItems.txt is not in any of the patches (but there is a file here: http://git.biblibre.com/?p=koha;a=blob;f=docs/opac/OpacHiddenItems.txt) Marking as "Failed QA". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #10 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-04 15:21:49 UTC --- The OpacHiddenItems.txt is in the "Proposed patch" attachment. The .pref file is still required though. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #11 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-04 15:40:58 UTC --- Created attachment 3644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3644 Adds the syspref in opac.pref -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3491|0 |1 is obsolete| | --- Comment #12 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:01:26 UTC --- Created attachment 3691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3691 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3492|0 |1 is obsolete| | --- Comment #13 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:03:22 UTC --- Created attachment 3692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3692 Followup patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3493|0 |1 is obsolete| | --- Comment #14 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:04:27 UTC --- Created attachment 3693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3693 Another follow up -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3644|0 |1 is obsolete| | --- Comment #15 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:05:09 UTC --- Created attachment 3694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3694 Adds the syspref in opac.pref -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #16 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:06:24 UTC --- The attached patches did not apply. I fixed them so they apply and updated the attachments. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3691|0 |1 is obsolete| | --- Comment #17 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:55:35 UTC --- Created attachment 3700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3700 Proposed Patch Previous version contained merge leftovers -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3692|0 |1 is obsolete| | --- Comment #18 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:56:50 UTC --- Created attachment 3701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3701 Followup patch Previous version contained merge leftovers -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3693|0 |1 is obsolete| | --- Comment #19 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2011-04-05 14:57:29 UTC --- Created attachment 3702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3702 Another follow up Previous version contained merge leftovers -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #20 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-05 15:09:38 UTC --- Created attachment 3703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3703 1st patch signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #21 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-05 15:10:02 UTC --- Created attachment 3704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3704 2nd patch signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #22 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-05 15:11:10 UTC --- Created attachment 3705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3705 3rd patch signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #23 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-05 15:11:33 UTC --- Created attachment 3706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3706 4th patch signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Patch Status|Needs Signoff |Signed Off --- Comment #24 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-05 15:13:22 UTC --- Tests done: - Display items of a biblio - filter items with OpacHiddenItems = itemcallnumber: [123] - Item with callnumber 123 disappear -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-10 07:44:54 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 lculber@mdah.state.ms.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lculber@mdah.state.ms.us --- Comment #26 from lculber@mdah.state.ms.us 2011-06-13 16:44:43 UTC --- We have found that while OpacHiddenItems seems to works in the opac-detail.pl in 3.4.1, the "hidden items" do appear once "specific copy" is selected on opac-reserve.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-13 21:39:52 UTC --- Thanks for testing Linda, I suggest we leave this bug open until someone has a chance to do a follow up for the reserve page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #28 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-19 15:22:04 UTC --- I'm not sure I agree with the approach this feature takes; specifying a large and complex set of criteria for bulk hiding of items makes for a very difficult feature to debug (as we've seen lately with this feature being broken). Wouldn't it make more sense to just add a "hidden" or "visibility" field to the items table? Then any item could be masked in the OPAC (or staff client). If we took in more than just 0 or 1, then we could have levels of invisibility (this would be good for biblio-level suppression, as well). For example, anonymous views can see hidden = 0, logged in users gain hidden = 1, staff can see hidden = 2, etc. We've got a bulk item editor, so making these changes in bulk would be pretty simple; we'd just need to identify the criteria. A small ergonomic change to the Reports interface to allow the direct pushing of a report to the bulk editor would make these convenient and seamless. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-23 10:45:52 UTC --- Ian, seems this patch has been pushed. Are you proposing to revert it ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #30 from lculber@mdah.state.ms.us 2011-11-23 13:52:46 UTC --- This feature has been working for us all along, and we'd hate to lose it. I have no idea why it works for us and no one else but it does, and it's still working in our test 3.6. Ours is like this: itype: [07, 10] location: [STAFF, ISO] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5984 --- Comment #31 from lculber@mdah.state.ms.us 2011-11-23 13:54:42 UTC --- This feature has been working for us all along, and we'd hate to lose it. I have no idea why it works for us and no one else but it does, and it's still working in our test 3.6. Ours is like this: itype: [07, 10] location: [STAFF, ISO] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org