http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20431&action=edit Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20431|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 20547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20547&action=edit Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested this with field 780 and running a Dutch translation. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: I know the author of the 6278 patch :) Since this construct works and is in the current code, we are making a consistent use of this workaround. Moving it to Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we please get another sign-off on this one? :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20547|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 20565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20565&action=edit Bug 10745 - More fun on translation bug with XSLT subfieldSelect parameters As in Bug 6278, this patch replace ">at<" with ">a_t<" so not to mislead translators. Found more cases that initial description. To test: 1) Check that problem exists and only on xslt files, using your preferred language egrep -B10 "^msgid \"at\"" misc/translator/po/xx-YY-i-staff-t* 2) Apply the patch 3) Update translation file (cd misc/translator; perl translate update xx-YY) 4) Verify the problem is gone, repeat 1 5) If you like verify new entries in PO file egrep -B15 "^msgid \"a_t\"" misc/translator/po/xx-YY-i-staff-t* Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested this with field 780 and running a Dutch translation. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10745 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.