https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75321&action=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> ---

6 - Note the column has a tooltip to indicate item vs. record holds

I think it would be very helpful if we could have a tooltip on the table cells too: "0 item holds / 3 total holds" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75321|0 |1 is obsolete| | --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 75489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75489&action=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75516&action=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75516|0 |1 is obsolete| | --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 75534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75534&action=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. There are "Show/hide columns" links on top of the page, the new column is not taken into account. 2. Maybe we could improve the tooltip "Holds on this record: 0" => "No hold on this record"? Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75533|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79429&action=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Rebasing (In reply to Jonathan Druart from comment #9)

1. There are "Show/hide columns" links on top of the page, the new column is not taken into account.

This was intentional, there are two other columns at the start that cannot be hidden, this seemed appropriate for the holds info. I will attempt a followup

2. Maybe we could improve the tooltip "Holds on this record: 0" => "No hold on this record"?

Will offer a followup shortly.

Failing QA for 1.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79429|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80170&action=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80705&action=edit Bug 19490: (follow-up) Improve tooltip message and some tidying -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- From commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea Bug 19490: Add a 'Holds' column to the items batchmodification tool This following line: + $this_row{item_holds} = Koha::Holds->search( itemnumber => $itemnumber )->count; displays a DBIC warning: [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl Must be ->search({ itemnumber => $itemnumber })->count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24051 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #19)

From commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea Bug 19490: Add a 'Holds' column to the items batchmodification tool

This following line: + $this_row{item_holds} = Koha::Holds->search( itemnumber => $itemnumber )->count;

displays a DBIC warning: [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl

Must be ->search({ itemnumber => $itemnumber })->count

See bug 24051. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated -- You are receiving this mail because: You are watching all bug changes.