[Bug 18179] New: Patron Restrictions not showing on member detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Bug ID: 18179 Summary: Patron Restrictions not showing on member detail page Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When a borrower has a restriction applied, the Restrictions tab on the Details screen doesn't show the restriction is there even though there's a message at the top of the screen saying the account is restricted. This does appear correctly on the circulation page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Version|16.11 |master --- Comment #1 from Marc Véron <veron@veron.ch> --- Confirmed for current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #2 from Marc Véron <veron@veron.ch> --- Hours of debugging later, one line of code messes up template params. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 62216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62216&action=edit Bug 18179: Patron Restrictions not showing on member detail page When a borrower has a restriction applied, the Restrictions tab on the Details screen (moremember.pl) doesn't show the restriction is there even though there's a message at the top of the screen saying the account is restricted. The restrictions appear correctly on the circulation page (circulation.pl). To test: - Apply patch - Verify that restrictions tab on moremember.pl behaves the same as on circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #4 from Marc Véron <veron@veron.ch> --- BTW: Syspref DumpTemplateVarsIntranet finally helped to find out that template variables were messed up. housebound_role got the variable name of the next template variable as value and all following template variables were wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron Restrictions not |Patron Restrictions not |showing on member detail |showing in tab on member |page |detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62216|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62218&action=edit [SIGNED-OFF] Bug 18179: Patron Restrictions not showing on member detail page When a borrower has a restriction applied, the Restrictions tab on the Details screen (moremember.pl) doesn't show the restriction is there even though there's a message at the top of the screen saying the account is restricted. The restrictions appear correctly on the circulation page (circulation.pl). To test: - Apply patch - Verify that restrictions tab on moremember.pl behaves the same as on circulation.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes we have a big problem here, it may be needed to fix it globally. For instance: in members/memberentry.pl 755 $template->param( 756 housebound_role => Koha::Patron::HouseboundRoles->find($borrowernumber), 757 ); If someone add a param: 755 $template->param( 756 housebound_role => Koha::Patron::HouseboundRoles->find($borrowernumber), 757 foo => 1, 758 ); housebound_role will be set to 'foo' if the patron does not have a housebound role, and foo will not be defined in the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron Restrictions not |Koha::Objects-find should |showing in tab on member |not be called in list |detail page |context Status|Signed Off |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15813 Assignee|veron@veron.ch |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Stealing this one for a more complete fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Objects-find should |Koha::Objects->find should |not be called in list |not be called in list |context |context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62218|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62304&action=edit Bug 18179: Forbid list context calls for Koha::Objects->find Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. Considering: $template->param( stuff => Koha::Stuffs->find( $id ), foo => 1, ); without this patch, if the $id does not represent any rows in the DB, stuff will be assigned to 'foo' and $foo will be undef in the template. That can lead to very bad side-effects. With this patch we make sure that it will never happen again. Test plan: prove t/db_dependent/Koha/Objects.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62305&action=edit Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- @RMaints, I would not backport the first patch, but the second one is safe ("Update existing calls"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62304|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 62319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62319&action=edit Bug 18179: Forbid list context calls for Koha::Objects->find Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. Considering: $template->param( stuff => Koha::Stuffs->find( $id ), foo => 1, ); without this patch, if the $id does not represent any rows in the DB, stuff will be assigned to 'foo' and $foo will be undef in the template. That can lead to very bad side-effects. With this patch we make sure that it will never happen again. Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62305|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 62321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62321&action=edit Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. Tested scripts changed by this patch, they work as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62319|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62656&action=edit Bug 18179: Forbid list context calls for Koha::Objects->find Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. Considering: $template->param( stuff => Koha::Stuffs->find( $id ), foo => 1, ); without this patch, if the $id does not represent any rows in the DB, stuff will be assigned to 'foo' and $foo will be undef in the template. That can lead to very bad side-effects. With this patch we make sure that it will never happen again. Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62321|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62657&action=edit Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. Tested scripts changed by this patch, they work as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@jns.fi --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 18492 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18511 [Bug 18511] Error loading booksellers.pl - Cannot use "->find" in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18510 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- This patch is causing errors with many new find calls that have not been updated by the patch set. I think it would be best if we waited until post-release to push it back into master. That way we can find all the errors without subjecting librarians to them ; ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18510 [Bug 18510] Errors on Patron Details page ( moremember.pl ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patch should not have been reverted: Bug 18179: Update existing calls It fixes the original issues. Where do you get errors? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62879&action=edit Bug 18179: Update 1 occurrence in booksellers.pl To test: 1 - Load http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=1 2 - Should get internal server erro 3 - Apply patch 4 - Reload 5 - Should not get error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62880&action=edit Bug 18179: Update 1 occurrence in moremember.pl Cannot use "->find" in list context at /home/vagrant/kohaclone/members/moremember.pl line 334. Test Plan: 1) Got to moremember.pl, note error 2) Apply this patch 3) Refresh page, no error! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 18511 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 18510 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This requires another QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, I think the last 3 patches should be pushed before the release. We could move the croak to its own bug report if you do not feel confident with it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note: 18361 also adds a subtest find. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Same include: [%- IF borrower.category.category_type == 'I' %] [%- IF category_type == 'I' %] I am having the feeling that it should be borrower.category_type when I am looking at GetMember. Note that this change in the last patch could be considered out of scope here.. Also wondering about this hardcoded category too. I do not see in the sample patron categories. Please explain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: If you move the first patch somewhere else and remove the category change, please update to Passed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #26)
Same include:
[%- IF borrower.category.category_type == 'I' %]
[%- IF category_type == 'I' %]
I am having the feeling that it should be borrower.category_type when I am looking at GetMember.
Yes, right. I found 3 occurrences where borrower is passed to the template: members/pay.pl: borrower => $borrower, members/paycollect.pl: borrower => $borrower, members/routing-lists.pl: borrower => $borrower, $borrower comes from GetMember. And from 1 members/moremember.pl (Koha::Patron) So the change does not make sense. But it's a regression of bug 12461, should be fixed elsewhere. Please have a look at bug 17829 to get rid of all these issues!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62879|0 |1 is obsolete| | Attachment #62880|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63106&action=edit Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. Tested scripts changed by this patch, they work as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> bsoletes: 62657 - Bug 18179: Update existing calls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63107&action=edit Bug 18179: Update 1 occurrence in booksellers.pl To test: 1 - Load http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=1 2 - Should get internal server erro 3 - Apply patch 4 - Reload 5 - Should not get error Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63108&action=edit Bug 18179: Update 1 occurrence in moremember.pl Cannot use "->find" in list context at /home/vagrant/kohaclone/members/moremember.pl line 334. Test Plan: 1) Got to moremember.pl, note error 2) Apply this patch 3) Refresh page, no error! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63109&action=edit Bug 18179: Use borrower.category_type in patron-title.inc I found 3 occurrences where borrower is passed to the template: members/pay.pl: borrower => $borrower, members/paycollect.pl: borrower => $borrower, members/routing-lists.pl: borrower => $borrower, $borrower comes from GetMember. And from 1 members/moremember.pl (Koha::Patron) So the change does not make sense. But it's a regression of bug 12461, should be fixed elsewhere. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62656|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 62656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62656 Bug 18179: Forbid list context calls for Koha::Objects->find See bug 18539 for this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 [Bug 18539] Forbid Koha::Objects->find calls in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #10)
@RMaints, I would not backport the first patch, but the second one is safe ("Update existing calls").
Tried to backport, but there is a conflict in pay.pl. Can you take a look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #31)
Created attachment 63108 [details] [review] Bug 18179: Update 1 occurrence in moremember.pl
This patch is not longer needed, see bug 18647. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #32)
Created attachment 63109 [details] [review] Bug 18179: Use borrower.category_type in patron-title.inc
Same as previous comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63832&action=edit [16.11.x] Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. Tested scripts changed by this patch, they work as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Only the first patch is needed for 16.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, first patch listed here and first patch pushed do both not apply? It also looks like a part of the patches has been reverted from master and the status here is "Passed QA" - confusing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #41 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. Picked the 16.11.x patch from here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Template process failed: undef error - Cannot use "->find" in list context at /usr/share/koha/masterclone/Koha/Club.pm line 51. You will find a few with git grep "return.*->find" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18870 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18870 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18870 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 [Bug 18870] Patron Clubs breaks when creating a club -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org