[Bug 32535] New: BorrowerUnwatedField syspref should not include borrowers.flags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Bug ID: 32535 Summary: BorrowerUnwatedField syspref should not include borrowers.flags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The syspref BorrowerUnwantedField includes a checkbox for "System permissions (flags)." Checking it has no apparent effect; one is still able to edit patron permissions with the box checked. It should be removed from the syspref options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144871&action=edit Bug 32535: Exclude flags from BorrowerUnwantedField system preference The system preference BorrowerUnwantedField includes a checkbox for "System permissions (flags)." Checking it has no apparent effect; one is still able to edit patron permissions with the box checked. This patch excludes the field from the selectable fields. To test: * Search for the BorrowerUnwantedField system prefernce * Verify that you can check/uncheck System permissions (flags) * Verify it doesn't have any effect, as permissions are not set from the patron edit form, but separately * Apply patch * Verify you no longer can check/uncheck the field in the system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144871|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 144873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144873&action=edit Bug 32535: Exclude flags from BorrowerUnwantedField system preference The system preference BorrowerUnwantedField includes a checkbox for "System permissions (flags)." Checking it has no apparent effect; one is still able to edit patron permissions with the box checked. This patch excludes the field from the selectable fields. To test: * Search for the BorrowerUnwantedField system prefernce * Verify that you can check/uncheck System permissions (flags) * Verify it doesn't have any effect, as permissions are not set from the patron edit form, but separately * Apply patch * Verify you no longer can check/uncheck the field in the system preference Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Andrew! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 [Bug 32544] borrowers.flags should not be an option in any BorrowerMandatory or BorrowerUnwanted sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Don't thank me yet! In signing off on this one I thought to look at all the other Unwanted and Mandatory field sysprefs and they all include flags as well. Filed bug 32544. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #4)
Don't thank me yet! In signing off on this one I thought to look at all the other Unwanted and Mandatory field sysprefs and they all include flags as well. Filed bug 32544.
Maybe you should think about joining the QA team ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144873|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 145261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145261&action=edit Bug 32535: Exclude flags from BorrowerUnwantedField system preference The system preference BorrowerUnwantedField includes a checkbox for "System permissions (flags)." Checking it has no apparent effect; one is still able to edit patron permissions with the box checked. This patch excludes the field from the selectable fields. To test: * Search for the BorrowerUnwantedField system prefernce * Verify that you can check/uncheck System permissions (flags) * Verify it doesn't have any effect, as permissions are not set from the patron edit form, but separately * Apply patch * Verify you no longer can check/uncheck the field in the system preference Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|BorrowerUnwatedField |BorrowerUnwantedField |syspref should not include |syspref should not include |borrowers.flags |borrowers.flags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32535 --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org