[Bug 20779] New: Style refresh for patron detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Bug ID: 20779 Summary: Style refresh for patron detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 20520 I have some style updates for the patron detail page (moremember.tt) which I think will make the page more readable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 [Bug 20520] Re-indent moremember.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75434&action=edit Screenshot of the patron detail page before the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75435&action=edit Screenshot of the patron detail page after the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75436&action=edit Bug 20779 - Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75436|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 75504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75504&action=edit Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That's a lot of buttons! Would not it be better to move the "edit" button on the same line as the header block ("Library use", "Alternate address", etc.)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like Jonathan's idea I think. Also (if not done already) it would be nice if in the future it would be easier to hide the edit buttons together with the sections. Unwanted fields does not apply to this screen and the buttons always have to be hidden separately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
That's a lot of buttons!
I've gotten feedback from librarians that the edit links were not visible enough. It's clearly an opinion, so we'll need to use our best judgement.
Would not it be better to move the "edit" button on the same line as the header block ("Library use", "Alternate address", etc.)?
The way I have it the edit button appears on the same line as the header if there is no content in the section, and at the bottom if there is. This is my preference, but I'm happy to be outvoted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75628&action=edit Screenshot highlighting markup structure.
Also (if not done already) it would be nice if in the future it would be easier to hide the edit buttons together with the sections.
I think I've already done what you're talking about. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Maybe we should ask on the list? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 [Bug 20809] Link patron image to patron image add/edit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75638&action=edit Screenshot showing buttons in line with headings Here is a screenshot of what it might look like with the edit buttons inline with headings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #10)
Created attachment 75638 [details] Screenshot showing buttons in line with headings
Here is a screenshot of what it might look like with the edit buttons inline with headings.
It does make sense to have buttons in sections headings, but then, I would like to see more space before headings, what do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75638|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75780&action=edit More polished version of buttons in line with headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #12)
Created attachment 75780 [details] More polished version of buttons in line with headings
That looks great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75504|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75855&action=edit Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Bug 20779 depends on bug 20520, which changed state. Bug 20520 Summary: Re-indent moremember.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Cab Vinton <director@plaistowlibrary.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 76968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76968&action=edit Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Cab Vinton <director@plaistowlibrary.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76968|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77092&action=edit Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Cab Vinton <director@plaistowlibrary.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23573 [Bug 23573] Labels and content overlapping on patron detail page and others for some languages -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org