[Bug 24378] New: Change wording on AUTO_RENEWALS notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Bug ID: 24378 Summary: Change wording on AUTO_RENEWALS notice template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On the template of AUTO-RENEWALS the wording is grammatically incorrect: Currently this line states: [% IF checkout.auto_renew_error == 'too_many' %] You have reach the maximum of checkouts possible. This should say [% IF checkout.auto_renew_error == 'too_many' %] You have reached the maximum of checkouts possible. Note: It should be eb installed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100309&action=edit Bug 24378: Correct wording in AUTO_RENEWAL notice Test Plan: - install patch - update databse - confirm notice name is now in sentence-case - confirm too-many error text now reads "reached" rather than "reach" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Easy fix to change that word, and I also adjusted the notice name while I was in there. But I'm not putting this to needs signoff yet because for some reason this notice isn't actually getting created in master and I'm not sure why. Will get some wiser eyes on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23787 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100309|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100416&action=edit Bug 24378: Reword notice in updatedatabase.pl for grammar and clarity Test plan: - install patch - update databse - confirm notice name is now in sentence-case - confirm too-many error text now reads "reached" rather than "reach" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Change wording on |Change wording on |AUTO_RENEWALS notice |AUTO_RENEWALS notice in |template |updatedatabase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100417&action=edit Bug 24378: atomicupdate for new wording -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100416|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 100479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100479&action=edit Bug 24378: Reword notice in updatedatabase.pl for grammar and clarity Test plan: - install patch - update databse - confirm notice name is now in sentence-case - confirm too-many error text now reads "reached" rather than "reach" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100417|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 100480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100480&action=edit Bug 24378: atomicupdate for new wording Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- After signing off, I though maybe that: "You have reached the maximum of checkouts possible." should be: "You have reached the maximum number of checkouts possible." (number added after maximum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100479|0 |1 is obsolete| | Attachment #100480|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100485&action=edit Bug 24378: Change wording of auto_renewals notice in updatedatabase Test plan: - install patch - update databse - confirm changes to notice name and wording -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Good catch! Added "number" as suggested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Andrew, you are adding a new notice template, but one can already exist. You should update existing ones, only if they have not been modified yet, and add it if does not exist yet. It seems that the template does not exist for new install, we should add it to the installer file (installer/data/mysql/en/mandatory/sample_notices.yml). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Hi Jonathan! I added it to sample-notices.yaml over in bug 23787. I'd already started work on this one before I found the other. What's the best way to link/merge the two? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Right, I had not seen the other bug. I would change the wording before adding it to the installer file. A good plan would be to: * Fix the wording for existing installs (you need to make sure it has not been modified or translated!) * Add the updated template for new installs (yml file) * Add the updated template for existing installs, if not exists yet (atomic update file) Maybe we could drop the first step, what do you think? The query would be quite ugly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should not run an updatedatabase here as suggested as the notice could have been translated or removed on purpose (the library not wanting to send it). We could do a replace on the string if the notice exists instead? There are some examples for this in the updatedatabase.pl file: UPDATE saved_sql SET savedsql = REPLACE(savedsql, 'wthdrawn', 'withdrawn'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Katrin makes a good point about not pushing this out to existing installs as they may have intentionally removed it. With that in mind, I'm going to close this bug. I'll iron out the other bug to get this notice with new wording into fresh installs. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Another option might be to use a 'REPLACE' in the updatedatabase to just change the text in question if it is still there. And we could still fix the initial updatedatabase statement. If it is ok with you, I might have a go at this later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- By all means, have at it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED Assignee|andrew@bywatersolutions.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100485|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102827&action=edit Bug 24378: Change wording of auto_renewals notice in updatedatabase On the template of AUTO-RENEWALS the wording is grammatically incorrect: [% IF checkout.auto_renew_error == 'too_many' %] You have reach the maximum of checkouts possible. This should say [% IF checkout.auto_renew_error == 'too_many' %] You have reached the maximum of checkouts possible. Test plan: - Make sure you have the AUTO_RENEWALS notice with the problematic spelling - install patch - update database - confirm changes to notice name and wording Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Kept Andrew's change on the original updatedatabase entry, but removed the database update to be done a little differently in a follow-up patch. Amended test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102828&action=edit Bug 24378: Database update to rewrite notice if left unchanged The database update makes the same changes as done by Andrew on the old database entry. We check for full sentences left unchanged to minimize issues with changes made by the library. Test plan of first patch applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23787 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This should be pushed together with bug 23787 - so we take care of this once and for all. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102827|0 |1 is obsolete| | Attachment #102828|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102871&action=edit Bug 24378: Change wording of auto_renewals notice in updatedatabase On the template of AUTO-RENEWALS the wording is grammatically incorrect: [% IF checkout.auto_renew_error == 'too_many' %] You have reach the maximum of checkouts possible. This should say [% IF checkout.auto_renew_error == 'too_many' %] You have reached the maximum of checkouts possible. Test plan: - Make sure you have the AUTO_RENEWALS notice with the problematic spelling - install patch - update database - confirm changes to notice name and wording Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Kept Andrew's change on the original updatedatabase entry, but removed the database update to be done a little differently in a follow-up patch. Amended test plan. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102872&action=edit Bug 24378: Database update to rewrite notice if left unchanged The database update makes the same changes as done by Andrew on the old database entry. We check for full sentences left unchanged to minimize issues with changes made by the library. Test plan of first patch applies. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104683&action=edit Bug 24378: (follow-up) Format due date as due date Changes the due date formatting as was already done for the new sample files on bug 23787. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think the indentation changes in the first patch are wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102871|0 |1 is obsolete| | Attachment #102872|0 |1 is obsolete| | Attachment #104683|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104701&action=edit Bug 24378: Change wording of auto_renewals notice in updatedatabase On the template of AUTO-RENEWALS the wording is grammatically incorrect: [% IF checkout.auto_renew_error == 'too_many' %] You have reach the maximum of checkouts possible. This should say [% IF checkout.auto_renew_error == 'too_many' %] You have reached the maximum of checkouts possible. Test plan: - Make sure you have the AUTO_RENEWALS notice with the problematic spelling - install patch - update database - confirm changes to notice name and wording Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Kept Andrew's change on the original updatedatabase entry, but removed the database update to be done a little differently in a follow-up patch. Amended test plan. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104702&action=edit Bug 24378: Database update to rewrite notice if left unchanged The database update makes the same changes as done by Andrew on the old database entry. We check for full sentences left unchanged to minimize issues with changes made by the library. Test plan of first patch applies. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104703&action=edit Bug 24378: (follow-up) Format due date as due date Changes the due date formatting as was already done for the new sample files on bug 23787. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104704&action=edit Bug 24378: (QA follow-up) fix minor issues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you for the follow-up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #30 from Joy Nelson <joy@bywatersolutions.com> --- missing dependencies - not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28258 [Bug 28258] Bad date formatting in AUTO_RENEWALS notice -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org