[Bug 28893] New: Unused opac/rss directory can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Bug ID: 28893 Summary: Unused opac/rss directory can be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS <link> tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124081&action=edit Bug 28893: Remove unused opac/rss directory RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS <link> tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. Test plan: Confirm that this directory is useless and can be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124081|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124088&action=edit Bug 28893: Remove unused opac/rss directory RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS <link> tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. Test plan: Confirm that this directory is useless and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Doing some investigation here... does someone know what misc/rss is for? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124088|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124219&action=edit Bug 28893: Remove unused opac/rss directory RSS feeds are now generated using opac/opac-search.pl (format=rss). But prior to commit 09df0de35fcb5b1645490bd3ec9d9a77ec7923a1 Removing obsolete RSS <link> tags and the scripts it was using opac/opac-rss.pl, which used opac/rss The directory should have been removed by this commit. Test plan: Confirm that this directory is useless and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #3)
Doing some investigation here... does someone know what misc/rss is for?
Where do you see it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, left out "cronjobs": https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/cr... I was just wondering as I can't remember seeing that one in documentation. From the original author in the README quite an old piece of Koha :) Discussion should totally happen elsewhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #6)
Sorry, left out "cronjobs": https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/ cronjobs/rss
I was just wondering as I can't remember seeing that one in documentation. From the original author in the README quite an old piece of Koha :) Discussion should totally happen elsewhere.
I never used this script prior to today, but they don't seem to work great. mostReserved.conf is using items.reserves which is not implemented, lastAcquired.conf generates a list of <item> <title>, by </title> <link>http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-detail.pl?biblionumber=435</link> </item> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org