https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Patch for discussion. Could you test and tell me if it could work for you? What features are missing? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I love it! What I remember from the presentation that's missing: - The left menu was removed when datatables were enabled to leave more space on the screen for the table. - Add a way to go back to "normal view" - Were there filters at the top of the columns, or was that something else? (Like if I do SELECT categorycode, surname, firstname, email FROM borrowers, there would be a dropdown at the top of the categorycode column to filter that column) But I might be misremembering that part and mixing it up with another presentation - There is no need for a 'Configure' button -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #3)

- The left menu was removed when datatables were enabled to leave more space on the screen for the table. - Add a way to go back to "normal view" - Were there filters at the top of the columns, or was that something else? (Like if I do SELECT categorycode, surname, firstname, email FROM borrowers, there would be a dropdown at the top of the categorycode column to filter that column) But I might be misremembering that part and mixing it up with another presentation - There is no need for a 'Configure' button

The plugin does not add a filtering option, just sorting/ordering. One can return to normal view by re-running the report, but that'd be annoying if your report has parameters to set. I agree a Return to Normal button would be helpful. The plugin adds an option to export as PDF. That seems handy, though I'm not sure it's really a datatables thing. The plugin defaults the datatables view to loading with word wrapping disabled and adds a button to enable word wrapping and adjust column width to fit everything in one window. I don't see a real need to default word wrap to off, but a fit-to-window button would be handy (for reports that aren't too too big). The plugin removes data menu links when switching to datatable view, which is not ideal. I like that your patch retains those links. However, it's causing those columns to sort as strings rather than as numbers. Testing with "SELECT * FROM biblio," the datatable view orders them 1,10,100,101, etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196706&action=edit Bug 42190: Add "Back to normal view" Patch from commit b8f14a3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Caroline Cyr La Rose from comment #3)

- The left menu was removed when datatables were enabled to leave more space on the screen for the table.

Added it as an option. There is now a collapse button in the sidebar: https://snipboard.io/6ERKcr.jpg But it is not perfectly positioned when collapsed: https://snipboard.io/wzPoNl.jpg

- Add a way to go back to "normal view"

Done.

- There is no need for a 'Configure' button

Indeed, removed. (In reply to Andrew Fuerste-Henry from comment #4)

One can return to normal view by re-running the report, but that'd be annoying if your report has parameters to set.

Not a problem, they are kept! :)

The plugin adds an option to export as PDF. That seems handy, though I'm not sure it's really a datatables thing.

If we want it it's for another bug (and should be applied to all tables). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Ilona R <hattara@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hattara@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196997&action=edit Bug 42190: Use num-html for itemnumber and biblionumber columns Patch from commit 64c9ad5 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Markus <mm.mpathy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mm.mpathy@gmail.com --- Comment #13 from Markus <mm.mpathy@gmail.com> --- (In reply to Jonathan Druart from comment #1)

Created attachment 196459 [details] [review] Bug 42190: Add DataTables to report results

This is a POC (i.e. not ready for inclusion yet) It adds a "Open in DataTables" button in the toolbar, that will refetch the report (with a limit=100000, that needs to be configurable, how?) and load the results in a kohaTable (DataTables)

Said limit is just the regular "reports_export_limit" parameter in the Koha Administration, and configurabel there. I added this information in the next release. My plugin doesnt refetch the result page itself, but fetches the data via the CSV Export function instead. This removes the massive overhead of the serverside HTML rendering and reduces it to only the data of the SQL query itself. Even big tables can be displayed like that (also, without the need for pagination to prevent server timeout) This means one can increase "reports_export_limit" drastically - but then should avoid the vanilla "Load all data" functionality in combination with that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Markus from comment #14)

I would like to provide some additional context regarding the questions raised here. This was just foundational version, and I plan to expand its functionality in future iterations.

I deliberately limited the feature set to remain compatible with the legacy DataTables version currently used in the Koha installation I used it for. While features like advanced sorting and filtering are easy to implement, they are currently restricted by the environment of the Koha Installation I made this plugin in for primarily. (This is also why I am advocating for an update to a more current and complete DataTables version within Koha).

It's going to be pushed soon, see bug 42003.

I’d specifically like to highlight the StateRestore plugin for DataTables, as a suggestion for integration, too. This would allow users who are not proficient in SQL, to perform complex queries and save them as "sub-results" by filtering the data and clicking "Save State" for future use. See also: https://datatables.net/extensions/staterestore/examples/

Yes, I had a look already, see bug 38296. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196997|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #18 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 197079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197079&action=edit Bug 42190: Add DataTables to report results This is a POC (i.e. not ready for inclusion yet) It adds a "Open in DataTables" button in the toolbar, that will refetch the report (with a limit=100000, that needs to be configurable, how?) and load the results in a kohaTable (DataTables) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #20 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 197081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197081&action=edit Bug 42190: Add "Back to normal view" Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #22 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 197083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197083&action=edit Bug 42190: Do not export the dropdown menu for itemnumbers, biblionumbers, cardnumbers and borrowernumbers Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #23 from Michaela Sieber <michaela.sieber@kit.edu> --- Test plan 1. Apply Patch Apply the patch associated with Bug 42190 Restart Koha services if required Verify that the system loads without errors Navigate to the reports module Create a report : select b.borrowernumber, -- verify data menu CONCAT('<a target="_blank" href=\"/cgi-bin/koha/members/moremember.pl?borrowernumber=', b.borrowernumber, '\">', b.borrowernumber, '</a>' ) AS "Borrower (HTML link)", -- dt-type-numeric, verify sort and export b.cardnumber, b.surname, b.firstname, b.branchcode, b.address, b.city, b.phone from borrowers b 2. Verify "Open in DataTables" Button Confirm the presence of the "Open in DataTables" button in the toolbar Click the button Verify: The report is reloaded The request uses a high limit (e.g., limit=100000) Data is displayed in DataTables format 3. Sorting Functionality Click on different column headers Verify: Data is sorted correctly (ascending/descending) Sorting works across multiple columns , e.g. sort by branch + surname (using shift) 4. Filtering Functionality Use the search/filter input field on top of the table Verify: Results update dynamically based on filter input Filtering works for different columns and values 5. Data Menus Validation Check the availability and behavior of data-related menus for: itemnumber biblionumber cardnumber borrowernumber Confirm: Links or actions open the correct records 6. Export Options Test all available export options (Excel, CSV, etc.) Verify: Exported files contain correct and complete data File formats are valid and readable Export reflects applied sorting/filtering 7. Return to Normal View Exit the DataTables view Verify: The interface returns to the standard report view No UI elements are broken or missing Original functionality is preserved Expected Results The "Open in DataTables" feature works correctly Large datasets are handled properly Sorting and filtering behave as expected Data menus link to correct records Export options function without errors Users can safely switch between DataTables and normal view -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197084&action=edit Bug 42190: Add DataTables to report results This is a POC (i.e. not ready for inclusion yet) It adds a "Open in DataTables" button in the toolbar, that will refetch the report (with a limit=100000, that needs to be configurable, how?) and load the results in a kohaTable (DataTables) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197086&action=edit Bug 42190: Add "Back to normal view" Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197088&action=edit Bug 42190: Do not export the dropdown menu for itemnumbers, biblionumbers, cardnumbers and borrowernumbers Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39394 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows release notes| |report results to be viewed | |with the DataTables | |feature used elsewhere in | |Koha. DataTables allows | |sorting by any column in | |the results as well as | |dynamic filtering. Export | |options within the | |DataTables view include a | |new Copy option and export | |data respecting the user's | |current sorting and | |filtering. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #29)

After BZ 42163 and 42003 pushed, columns with data menus (biblionumber, itemnumber, borrowernumber, cardnumber) have some trouble. They sort as strings rather than numbers (1,10,100,2). Also, sorting the column causes the data menu options to reappear if one has hidden them.

To recreate: apply patch - make a report "select biblionumber from biblio" - observe numbers in number order - open in datatables - observe numbers in string order - click "Hide data menus" - click biblionumber column header to reorder column - observe the data menu links come back but the data menus button still says "show data menus" - edit your report, renaming column to remove data menus -- "select biblionumber as bibble from biblio" - run report, open in datatables, observe it sorts correctly

Given that we enter soft feature freeze today I am wondering if that could be handled as a follow-up if the feature itself works apart from the sorting of numerical columns? I think this would make a great feature for 26.05. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #31 from Michaela Sieber <michaela.sieber@kit.edu> --- I also support handling this as a follow-up, since it’s not a critical error. While it’s not ideal that the sorting of the ID numbers in the data menus is done in string order, it’s only a trivial issue and therefore shouldn’t block the feature. Additionally, the use of the data table button is optional anyway, so the existing report results will not be negatively affected. The follow-up can then be treated as a bug and could be addressed next week. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198154&action=edit Bug 42190: (QA follow-up) use num-html for itemnumber, biblionumber, borrowernumber, and cardnumber Patch from commit 5731027 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #35 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.