[Bug 7207] New: Cannot export label batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Bug #: 7207 Summary: Cannot export label batches Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Label printing AssignedTo: cnighswonger@foundations.edu ReportedBy: wizzyrea@gmail.com QAContact: ian.walls@bywatersolutions.com http://screencast.com/t/hthSz0Uz5 We discussed this on IRC - this is just the formal bug report. See also Bug 6679, which should have the patch applied that will fix this error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6679 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6697 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-11-11 17:59:54 UTC --- This will be fixed by the application of these two patches: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6270 http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6271 in that order. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-11-11 18:18:28 UTC --- Created attachment 6295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6295 [Signed off] Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script. squashed chris_n's two patches. Label export works again. Don't change $_ in a list context Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent CC| |wizzyrea@gmail.com Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-14 17:36:34 UTC --- The line: @item_numbers = grep{my $number=$_; $number = {item_number => $number}} @item_numbers; follows the same pattern as the two lines above; should it not also be reverted? Can we confirm that labels with multiple item numbers work properly with this change still in place? What this original commit was trying to fix vs. what it actually did here seems divergent... the original bug report is about declaring variables in conditionals. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-11-14 20:49:29 UTC --- Created attachment 6307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6307 Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script. squashed chris_n's two patches. Label export works again. Also changed the pattern for the item_number to the known working, critic friendly pattern. Don't change $_ in a list context Changed the 3rd bit to the critic friendly pattern chris_n suggests in the previous two lines. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6295|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> 2011-11-14 20:50:35 UTC --- This latest attachment will need a new signoff, as it's got an additional change in it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> 2011-11-15 18:03:01 UTC --- Created attachment 6313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6313 Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script. squashed chris_n's two patches. Label export works again. Also changed the pattern for the item_number to the known working, critic friendly pattern. Don't change $_ in a list context Changed the 3rd bit to the critic friendly pattern chris_n suggests in the previous two lines. Signed-off-by: Brendan <brendan@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6307|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-15 18:05:50 UTC --- Updated bug has second signoff, and the fix pattern has been extended to all three lines, so I'm going to mark this one as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Passed QA |Patch Pushed --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-16 17:12:22 UTC --- Patch pushed, BUT : * the screen cast did not work for me (I had a FF screen that was all black -and I don't speak about Rugby here ;-) ) * could not test the fix, I just can say the label-print.pl still compiles. SO : PLEASE DOUBLE TEST ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 --- Comment #9 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-16 23:46:43 UTC --- Updated a library partner of ours that was having a problem: they say it's now fixed in Firefox, but they're still having issues in IE. Since IE is never a good idea for the staff client, we're okay with the outcome. Consider this "one more data point" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 - low Patch Status|Patch Pushed |--- Severity|major |trivial --- Comment #10 from Liz Rea <wizzyrea@gmail.com> 2011-12-08 19:38:23 UTC --- Re-marking as trivial due to the problem with IE - would be nice to get a fix for that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6313|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot export label batches |Cannot export label batches | |in IE -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |WONTFIX --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 16:14:26 UTC --- IE is not expected to work, so marking "RESO WONTFIX" for the IE problem. The other problem IS fixed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Bug 7207 depends on bug 6697, which changed state. Bug 6697 Summary: Empty Organisation(s) field for organisational patrons http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6697 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org