[Bug 9376] New: Problem with dateexpiry display in moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Bug ID: 9376 Summary: Problem with dateexpiry display in moremember.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: vfernandes@keep.pt CC: gmcharlt@gmail.com There is a problem that brokens the interface of moremmeber when displaying the date expiry caused by this line: <strong class="reregistryinfo">[% dateexpiry %]</span> It should be: <span class="reregitryinfo">[% dateexpiry %]</span> It happens in version 3.8. In version 3.10, I don't know if the problem happens. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |vfernandes@keep.pt |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 --- Comment #1 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 14529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14529&action=edit Bug 9376: Problem with dateexpiry display in moremember.tt There is a problem that brokens the interface of moremmeber when displaying the date expiry when renewing a patron. In the first comment I said that the line that causes the error should be: <span class="reregitryinfo">[% dateexpiry %]</span> but the correct way should be: <strong class="reregitryinfo">[% dateexpiry %]</strong> This way the date expiry after renew a patron appears in bold. Test plan: - after apply the patch try to renew a patron and check that almost everything went bold - apply the patch - renew a patron and only the date expiry is bolder. Sponsored-by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Confirmed that this affect 3.10.x. It doesn't affect master, but only because of how the patch for bug 6261 reworks the member toolbar to use member/setstatus.pl rather than members/moremember.pl to renew the patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14529|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14628&action=edit Bug 9376: Problem with dateexpiry display in moremember.tt There is a problem that brokens the interface of moremmeber when displaying the date expiry when renewing a patron. In the first comment I said that the line that causes the error should be: <span class="reregitryinfo">[% dateexpiry %]</span> but the correct way should be: <strong class="reregitryinfo">[% dateexpiry %]</strong> This way the date expiry after renew a patron appears in bold. Test plan: - before applying the patch try to renew a patron and check that almost everything went bold - apply the patch - renew a patron and only the expiration date is bolder. - Note that the bug doesn't manifest in master because the patch for bug 6261 causes the invalid HTML to never be reached; it *does* affect 3.10.x and earlier. Sponsored-by: KEEP SOLUTIONS Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14629&action=edit Bug 9376: extend HTML fix to moremember-brief.tt Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Note that I added a follow-up patch along with my signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9406 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The patch fixes a malformed strong tag. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14628|0 |1 is obsolete| | Attachment #14629|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14662&action=edit Bug 9376: Problem with dateexpiry display in moremember.tt There is a problem that brokens the interface of moremmeber when displaying the date expiry when renewing a patron. In the first comment I said that the line that causes the error should be: <span class="reregitryinfo">[% dateexpiry %]</span> but the correct way should be: <strong class="reregitryinfo">[% dateexpiry %]</strong> This way the date expiry after renew a patron appears in bold. Test plan: - before applying the patch try to renew a patron and check that almost everything went bold - apply the patch - renew a patron and only the expiration date is bolder. - Note that the bug doesn't manifest in master because the patch for bug 6261 causes the invalid HTML to never be reached; it *does* affect 3.10.x and earlier. Sponsored-by: KEEP SOLUTIONS Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14663&action=edit Bug 9376: extend HTML fix to moremember-brief.tt Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9376 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org