[Bug 43519] New: Direct links to article request form still work when the feature is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Bug ID: 43519 Summary: Direct links to article request form still work when the feature is disabled Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- When ArticleRequests are turned off, the page in the OPAC should no longer be reachable by direct link. .../cgi-bin/koha/opac-request-article.pl?biblionumber=xxx There is also no error on saving the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- # Bug Update for Bug 43519 - Direct links to article request form still work when the feature is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206141&action=edit Bug 43519: Direct links to article request form still work when the feature is disabled This patch adds a check for the ArticleRequests system preference in opac-request-article.pl so that the page will return a 404 error if the preference is disabled. To test, apply the patch and restart services. - If necessary, enable the ArticleRequests system preference and configure a circulation rule to allow article requests. - Locate a bibliographic record in the OPAC which will accept an article request. Note the biblionumber of the record you select. - Click "Request article" and complete the process. It should finish successfully. - Disable the ArticleRequests system preference. - Return to the OPAC and navigate directly to the page for requesting an article: http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=X ...where X is the biblionumber you noted before. - This should trigger a 404 error. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks so much Owen for taking this one on. I will be mostly away from computers for the next 2 weeks until KohaCon - but hope I will get to it after (or maybe someone else wants to beat me to it?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 --- Comment #4 from Bastien Chauvet <bastien.chauvet@inlibro.com> --- Created attachment 206193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206193&action=edit Bug 43519: Direct links to article request form still work when the feature is disabled This patch adds a check for the ArticleRequests system preference in opac-request-article.pl so that the page will return a 404 error if the preference is disabled. To test, apply the patch and restart services. - If necessary, enable the ArticleRequests system preference and configure a circulation rule to allow article requests. - Locate a bibliographic record in the OPAC which will accept an article request. Note the biblionumber of the record you select. - Click "Request article" and complete the process. It should finish successfully. - Disable the ArticleRequests system preference. - Return to the OPAC and navigate directly to the page for requesting an article: http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=X ...where X is the biblionumber you noted before. - This should trigger a 404 error. Sponsored-by: Athens County Public Libraries Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Bastien! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206193|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206280&action=edit Bug 43519: Direct links to article request form still work when the feature is disabled This patch adds a check for the ArticleRequests system preference in opac-request-article.pl so that the page will return a 404 error if the preference is disabled. To test, apply the patch and restart services. - If necessary, enable the ArticleRequests system preference and configure a circulation rule to allow article requests. - Locate a bibliographic record in the OPAC which will accept an article request. Note the biblionumber of the record you select. - Click "Request article" and complete the process. It should finish successfully. - Disable the ArticleRequests system preference. - Return to the OPAC and navigate directly to the page for requesting an article: http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=X ...where X is the biblionumber you noted before. - This should trigger a 404 error. Sponsored-by: Athens County Public Libraries Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43519 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org