https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156323&action=edit Bug 34944: Remove the use of event attributes from OPAC full serial issue page This patch removes the use of event attributes (onclick) from the OPAC's full serial issues template. These events are defined now along with the other in-page JS. To test you must have a serial record with issues from multiple years. - Locate the serial record and view the detail page. - Click "More details" at the bottom of the "Subscriptions" tab. - Click the "Full history" tab. - Test the "Show year" controls to confirm that clicking each year correctly filters the table of issues to show only issues from that year. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) testing notes:

To test you must have a serial record with issues from multiple years.

create a subscription (no very frequent to not need tons of issues per year) => receive => multi receive => tons!!!! => here you go, you should have a few years -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156358|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156364&action=edit Bug 34944: Remove the use of event attributes from OPAC full serial issue page This patch removes the use of event attributes (onclick) from the OPAC's full serial issues template. These events are defined now along with the other in-page JS. To test you must have a serial record with issues from multiple years. - Locate the serial record and view the detail page. - Click "More details" at the bottom of the "Subscriptions" tab. - Click the "Full history" tab. - Test the "Show year" controls to confirm that clicking each year correctly filters the table of issues to show only issues from that year. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.