[Bug 24852] New: XSLT paths not adjusted for dev installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Bug ID: 24852 Summary: XSLT paths not adjusted for dev installs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org We are building the XSLT paths with intrahtdocs, it should be intranetdir (and assume that have the usual git structure) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100589&action=edit Bug 24852: Adjust XSLT paths for dev installs We are building the XSLT paths with intrahtdocs, it should be intranetdir (and assume that have the usual git structure). For instance, on a dev box, the XSLT base path was outside of the git repo: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/ Now it will be: /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/ Test plan: 0. Do not apply the patch, set dev_install to 1 in $KOHA_CONF 1. Modify a xslt in the git repo, and in the "htdocs" path, in a different way: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl 2. Restart all the things and refresh a bibliographic record detail page Notice that you see the change from the "htdocs", outside of the git repo 3. Apply the patch 4. Repeat 2. Notice that you now see the change you made on the file from the git repo 5. Set dev_install to 0 in $KOHA_CONF 6. Repeat 2. Notice that you now see the change from htdocs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We need that, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #2)
We need that, right?
Yes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Do we need more? For a gitify I am doing this for koha-conf: s/koha\/opac\/cgi-bin\/opac/koha\/opac/ s/koha\/opac\/htdocs/koha\/koha-tmpl/ s/koha\/intranet\/cgi-bin/koha/ s/koha\/intranet\/htdocs/koha\/koha-tmpl/ s/doc\/koha-common/koha\/docs/ s/bin\/cronjobs/misc\/cronjobs/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Maybe, I do not know exactly what is missing. In debian scripts we are testing the dev_install config flag, so I think it makes sense to test it from the code as well. Or we go backward, remove the specific paths and adjust KOHA_CONF? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)
Maybe, I do not know exactly what is missing. In debian scripts we are testing the dev_install config flag, so I think it makes sense to test it from the code as well.
Or we go backward, remove the specific paths and adjust KOHA_CONF?
I am open for both solutions.
From a maintenance perspective it may be easier to adjust some koha-conf paths in a Dockerfile or so than duplicating code in various places. Note that the dev_install flag helped us to run the debian scripts as-is without gitifying them as well.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I never liked the way we specify things in the koha-conf.xml file :-D If we did that, we would need: intrahtdocs intracgidir opachtdocs opaccgidir and why not something for the API as well... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #7)
I never liked the way we specify things in the koha-conf.xml file :-D
If we did that, we would need: intrahtdocs intracgidir opachtdocs opaccgidir and why not something for the API as well...
I have the impression that you did not understand me or vice versa :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have the feeling that we are going to far. I would go for this patch, it's simple and written. Then we can discuss something bigger on a separate bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #8)
(In reply to Tomás Cohen Arazi from comment #7)
I never liked the way we specify things in the koha-conf.xml file :-D
If we did that, we would need: intrahtdocs intracgidir opachtdocs opaccgidir and why not something for the API as well...
I have the impression that you did not understand me or vice versa :)
I understand what you propose and I like it. I just took the chance to say I never liked our current config. And I love the dev_install thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)
I have the feeling that we are going to far. I would go for this patch, it's simple and written. Then we can discuss something bigger on a separate bug report?
Well, this would be the first occurrence in a perl module. So it is not only a matter of "I wrote it already". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |koha-bugs@lists.koha-commun |ommunity.org |ity.org Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #12 is|1 |0 private| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just saying, that's definitely a bug. It works for the OPAC, only. Please suggest something if you disagree with this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)
Just saying, that's definitely a bug. It works for the OPAC, only.
Please suggest something if you disagree with this patch.
I dont object to it. But former comments still apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #14)
(In reply to Jonathan Druart from comment #13)
Just saying, that's definitely a bug. It works for the OPAC, only.
Please suggest something if you disagree with this patch.
I dont object to it. But former comments still apply.
Which ones? The one where you ask if we need more paths? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15)
(In reply to Marcel de Rooy from comment #14)
(In reply to Jonathan Druart from comment #13)
Just saying, that's definitely a bug. It works for the OPAC, only.
Please suggest something if you disagree with this patch.
I dont object to it. But former comments still apply.
Which ones? The one where you ask if we need more paths?
6/11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
2. Restart all the things and refresh a bibliographic record detail page Notice that you see the change from the "htdocs", outside of the git repo
That's puzzling, I see the git repo version. Can't find the issue after double checking.
6. Repeat 2. Notice that you now see the change from htdocs
Still git version. So with and without the patch. With dev_install 1 and dev_install 0, I always see the git repo version. A diff between the two files confirmed the difference. Does anyone else has the same issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Needs Signoff |RESOLVED Summary|XSLT paths not adjusted for |XSLT paths not adjusted for |dev installs |non-dev_install Resolution|--- |WONTFIX --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #17)
So with and without the patch. With dev_install 1 and dev_install 0, I always see the git repo version. A diff between the two files confirmed the difference.
Does anyone else has the same issue?
Hum indeed. There is something that changed somewhere but I cannot find what/where. So there is still an issue but less important. Marking as won't fix (for now at least). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org