[Bug 18377] New: Add Plack/PSGI file for dev install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Bug ID: 18377 Summary: Add Plack/PSGI file for dev install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Koha lacks a proper Plack file for dev install. debian/templates/plack.psgi is for package install and misc/plack/koha.psgi seems a bit outdated (you need 2 plack servers running — 1 for opac and 1 for intranet — and the REST API is not enabled in it) I'll attach a new one, based on debian/templates/plack.psgi but suited for a dev install -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 61812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61812&action=edit Bug 18377: Add PSGI file for dev install It is very similar to the one for debian install, but uses FindBin to set the paths -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Test plan: 1. Install koha in dev mode 2. Run `starman /your/koha/install/app.psgi` 3. Configure your webserver as a reverse proxy for starman (there is some examples for apache in debian/templates/apache-shared-*-plack.conf) 4. Verify that you can access OPAC, intranet and the REST API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do not you update misc/plack/koha.psgi? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Why do not you update misc/plack/koha.psgi?
I would have deleted it but I figured it may be used somewhere. Maybe we could add a deprecation warning in it before deleting it. As to why I think /app.psgi is a better place, it's because you can just cd to koha directory and run starman without any arguments (you don't have to look after the psgi file), and it will work. But I'm not strongly against updating misc/plack/koha.psgi if you still think it's better. I can make a new patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- s/look after/look for/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan, could you take another look here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not sound like a good idea to add a third .psgi file to maintain/update. Tomas, what is your feeling about this change/need? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #7)
It does not sound like a good idea to add a third .psgi file to maintain/update.
My first intention was to move debian/templates/plack.psgi into app.psgi and remove misc/plack/ but I felt that it would have prevented a quick integration into master... I believe that we should have one (and only one) psgi file, it should not be hidden in debian/ directory, and it should work out-of-the box on dev installs. Changing status to In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16733 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to Julian Maurice from comment #0)
Koha lacks a proper Plack file for dev install. debian/templates/plack.psgi is for package install and misc/plack/koha.psgi seems a bit outdated
hi Julian i think BZ16733 now provides DEV_INSTALL support in the debian/templates/plack.psgi file so, this issue is now resolved? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20393 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 16733 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Mason James from comment #9)
(In reply to Julian Maurice from comment #0)
Koha lacks a proper Plack file for dev install. debian/templates/plack.psgi is for package install and misc/plack/koha.psgi seems a bit outdated
hi Julian
i think BZ16733 now provides DEV_INSTALL support in the debian/templates/plack.psgi file
so, this issue is now resolved? Sort of. I still believe that the main entry point for Koha should be outside of the debian/ directory, and that the "debian case" should be treated as a specific case, rather than the default. But this "problem" would be solved if we decide to use a web framework like suggested in bug 20582, so this bug is obsolete anyway.
-- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org