[Bug 14916] New: Remove C4::Dates from circ/overdue.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Bug ID: 14916 Summary: Remove C4::Dates from circ/overdue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Patch to remove deprectated C4::Dates from circ/overdue.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Blocks| |14870 Assignee|gmcharlt@gmail.com |veron@veron.ch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 42927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42927&action=edit Bug 14916 - Remove C4::Dates from circ/overdue.pl Patch to remove deprectated C4::Dates from circ/overdue.pl To test: - Tests without patch: - Make sure that you have patron(s) with overdues. - Go to Home > Circulation > Overdues - Apply date filter, perform CSV download Apply patch, then - Reload page - Check that everything behaves as before -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42927|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 42928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42928&action=edit Bug 14916 - Remove C4::Dates from circ/overdue.pl Patch to remove deprectated C4::Dates from circ/overdue.pl To test: - Tests without patch: - Make sure that you have patron(s) with overdues. - Go to Home > Circulation > Overdues - Apply date filter, perform CSV download Apply patch, then - Reload page - Check that everything behaves as before -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42928|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43344&action=edit [SIGNED-OFF]Bug 14916 - Remove C4::Dates from circ/overdue.pl Patch to remove deprectated C4::Dates from circ/overdue.pl To test: - Tests without patch: - Make sure that you have patron(s) with overdues. - Go to Home > Circulation > Overdues - Apply date filter, perform CSV download Apply patch, then - Reload page - Check that everything behaves as before Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43344|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43375&action=edit Bug 14916: Display overdues if due on 23:59 If an item is due on today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Summary|Remove C4::Dates from |Overdues are not listed if |circ/overdue.pl |due on 23:59 of the 'to | |date' (Was: Remove | |C4::Dates from | |circ/overdue.pl) Severity|enhancement |normal Assignee|veron@veron.ch |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, Sorry to steal your bug (again), but I think I have found a bug on master. Could you please confirm? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 --- Comment #6 from Marc Véron <veron@veron.ch> --- Hi Jonathan, No problem, steal as much as you like :-) And confirmed, sign-off follows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43375|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 43405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43405&action=edit Bug 14916: Display overdues if due on 23:59 If an item is due on today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). Issue reproduced, it's resloved with this patch. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43405|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43567&action=edit [PASSED QA] Bug 14916: Display overdues if due on 23:59 If an item is due today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). Issue reproduced, it's resolved with this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org