[Bug 29229] New: Use Flatpickr in suggestion search sidebar filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Bug ID: 29229 Summary: Use Flatpickr in suggestion search sidebar filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 28983 The suggestion entry form was upgraded to use Flatpickr but missed the jQueryUI datepickers in the suggestion search sidebar. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983 [Bug 28983] Use Flatpickr on various pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126235&action=edit Bug 29229: Use Flatpickr in suggestion search sidebar filter This patch corrects the date field configurations for the suggestions sidebar filter. These fields are now linked Flatpickr widgets instead of jQueryUI datepickers. To test, apply the patch and go to Suggestions. - In the sidebar, click "Suggestion information" to expand the form. - Test these linked date fields: - "Suggested date from" and "to" - "Managed date from" and "to" - "Accepted by from" and "to" - Each should trigger Flatpickr calendars which are linked, i.e. you can't select a "to" date which is before a "from" date. - Test that the dates submit correctly to filter as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126235|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126261&action=edit Bug 29229: Use Flatpickr in suggestion search sidebar filter This patch corrects the date field configurations for the suggestions sidebar filter. These fields are now linked Flatpickr widgets instead of jQueryUI datepickers. To test, apply the patch and go to Suggestions. - In the sidebar, click "Suggestion information" to expand the form. - Test these linked date fields: - "Suggested date from" and "to" - "Managed date from" and "to" - "Accepted by from" and "to" - Each should trigger Flatpickr calendars which are linked, i.e. you can't select a "to" date which is before a "from" date. - Test that the dates submit correctly to filter as expected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126261|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126466&action=edit Bug 29229: Use Flatpickr in suggestion search sidebar filter This patch corrects the date field configurations for the suggestions sidebar filter. These fields are now linked Flatpickr widgets instead of jQueryUI datepickers. To test, apply the patch and go to Suggestions. - In the sidebar, click "Suggestion information" to expand the form. - Test these linked date fields: - "Suggested date from" and "to" - "Managed date from" and "to" - "Accepted by from" and "to" - Each should trigger Flatpickr calendars which are linked, i.e. you can't select a "to" date which is before a "from" date. - Test that the dates submit correctly to filter as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29270 Depends on| |29241 Status|Passed QA |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We must remove flatpickr instantiation from .tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29241 [Bug 29241] Flatpickr not displaying date in the past for futuredate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126930&action=edit Bug 29229: (follow-up) Update method for linking flatpickr fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Bug 29229 depends on bug 29241, which changed state. Bug 29241 Summary: Flatpickr not displaying date in the past for futuredate https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29241 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31158 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 [Bug 31158] Can't filter suggestions by date ranges -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31158 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 [Bug 31158] Can't filter suggestions by date ranges -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org