[Bug 25388] New: There is no link for the "online help"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Bug ID: 25388 Summary: There is no link for the "online help" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org When editing a subfield, there is: Max length: XXXX (see online help) We should either link to the online help or remove it. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt: <li><label for="maxlength[% loo.row | html %]">Max length:</label><input type="text" id="maxlength[% loo.row | html %]" name="maxlength" value="[% loo.maxlength | html %]" size="4" /> (see online help)</li> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- There is actually nothing in the online help about this (as far as I can see) so I think it is best to remove it. It seems fairly self explanatory anyway, and I don't see what other information the online help could provide. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104514&action=edit Bug 25288: (follow-up) Use .escapeHtml() Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #104514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Wrong bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 --- Comment #5 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104532&action=edit Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Looks fine but fails QA tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt OK filters FAIL forbidden patterns forbidden pattern: tab char (line 131) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template I see this happen when I cut and paste sometimes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Lucas Gass from comment #6)
Looks fine but fails QA tool:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt OK filters FAIL forbidden patterns forbidden pattern: tab char (line 131) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template
I see this happen when I cut and paste sometimes.
That's odd - I deleted data from the end of that line, I didn't copy and paste anything! I think this might have been a 'legacy tab" from a previous edit in the past. I've removed it now anyway, so changed back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104532|0 |1 is obsolete| | --- Comment #8 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104543&action=edit Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. Remove tabs from start of line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104543|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104553&action=edit Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. Remove tabs from start of line Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Removing a little bit of text - setting to PQA directly. Thx David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, 19.05.x released in| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25388 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06, 19.05.x |20.05.00, 19.11.06, released in| |19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org