[Bug 21581] New: Matching rules for authorities do not respect 'Search index' setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Bug ID: 21581 Summary: Matching rules for authorities do not respect 'Search index' setting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When 'Search index' is passed to C4/AuthoritiesMarc.pm it is matched against a preset list, then defaulted to all - we should allow to pass through arbitrary indexes To recreate: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80658&action=edit Bug 21581: Pass through authorities indexes FIXME: We need unit tests To test: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' 12 - Apply patch 13 - Reapply matching 14 - Note we search the expected index and no match is found -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80658|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80665&action=edit Bug 21581: Pass through authorities indexes FIXME: We need unit tests To test: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' 12 - Apply patch 13 - Reapply matching 14 - Note we search the expected index and no match is found NOTE: By applying bug 21579, I was able to view the difference, and see that it didn't match identically, because I had moved the value from 010 to 155. No log checking needed. clean/delete batch. Apply patch, no match. clean/delete batch. Edit authority back, matches. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81064&action=edit Bug 21581: Unit tests and updated data To test: 1 - Apply this patch only 2 - prove -v t/db_dependent/Search.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/Search.t 6 - It passes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80665|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81065&action=edit Bug 21581: Pass through authorities indexes To test: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' 12 - Apply patch 13 - Reapply matching 14 - Note we search the expected index and no match is found NOTE: By applying bug 21579, I was able to view the difference, and see that it didn't match identically, because I had moved the value from 010 to 155. No log checking needed. clean/delete batch. Apply patch, no match. clean/delete batch. Edit authority back, matches. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am having a bit of trouble with the test here - also on master: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Search.t t/db_dependent/Search.t .. # Failed test 'All records have at least one item available' # at t/db_dependent/Search.t line 464. # got: 'false' # expected: 'true' Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan.pm line 53. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan/node.pm line 102. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan/node.pm line 102. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan/node.pm line 102. Negative repeat count does nothing at /home/vagrant/kohaclone/Koha/QueryParser/Driver/PQF/query_plan/node.pm line 102. # Looks like you failed 1 test of 109. t/db_dependent/Search.t .. 1/2 # Failed test 'MARC21 + DOM' # at t/db_dependent/Search.t line 939. t/db_dependent/Search.t .. 2/2 # Looks like you failed 1 test of 2. t/db_dependent/Search.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/Search.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Maybe someone else can have a look? Patch seems clear enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81064|0 |1 is obsolete| | Attachment #81065|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81599&action=edit Bug 21581: Unit tests and updated data To test: 1 - Apply this patch only 2 - prove -v t/db_dependent/Search.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/Search.t 6 - It passes! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81600&action=edit Bug 21581: Pass through authorities indexes To test: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' 12 - Apply patch 13 - Reapply matching 14 - Note we search the expected index and no match is found NOTE: By applying bug 21579, I was able to view the difference, and see that it didn't match identically, because I had moved the value from 010 to 155. No log checking needed. clean/delete batch. Apply patch, no match. clean/delete batch. Edit authority back, matches. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81601&action=edit Bug 21581: (QA follow-up) Update comment according to code in SearchAuthorities Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06. RMaint followup added to prevent, long deprecated, GRS-1 test from running against this new bugfix/enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- CC| |januszop@gmail.com --- Comment #12 from Janusz Kaczmarek <januszop@gmail.com> --- I seems to me that this patch creates a problem with Zebra searches while queryparser is off. Could you please verify the following scenario: search engine zebra, query parser off, and let's do an authority search for e.g. authority number or whatsoever with "Search entire record" (the forth option). Zebra gets the query: @or @attr 1=Heading @attr 7=1 0 @attr 4=6 @attr 5=1 @attr 1=all <search term> and answers ERROR 114, that is unknown use attribute. In fact, the attr-1 'all' is not defined. Before that patch 'all' was changed into @attr 1=Any. Now it seems to create problems. Tests were done with 18.05.06. Thank you for verifying this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #13 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Janusz Kaczmarek from comment #12)
It seems to me that this patch creates a problem with Zebra searches while queryparser is off.
Could you please verify the following scenario: search engine zebra, query parser off, and let's do an authority search for e.g. authority number or whatsoever with "Search entire record" (the forth option). Zebra gets the query:
@or @attr 1=Heading @attr 7=1 0 @attr 4=6 @attr 5=1 @attr 1=all <search term>
and answers ERROR 114, that is unknown use attribute. In fact, the attr-1 'all' is not defined. Before that patch 'all' was changed into @attr 1=Any. Now it seems to create problems.
Tests were done with 18.05.06.
Thank you for verifying this.
My fast work around is: --- a/C4/AuthoritiesMarc.pm +++ b/C4/AuthoritiesMarc.pm @@ -163,6 +163,9 @@ sub SearchAuthorities { elsif ( @$tags[$i] eq "thesaurus" ) { $attr = " \@attr 1=Subject-heading-thesaurus "; } + elsif ( @$tags[$i] eq "all" ) { + $attr = " \@attr 1=Any "; + } else { # Use the index passed in params $attr = " \@attr 1=" . @$tags[$i] . " "; } but I'm not sure if it wouldn't destruct the idea of the author of this patch, so I'm not submitting it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Janusz Kaczmarek from comment #13)
(In reply to Janusz Kaczmarek from comment #12)
It seems to me that this patch creates a problem with Zebra searches while queryparser is off.
Could you please verify the following scenario: search engine zebra, query parser off, and let's do an authority search for e.g. authority number or whatsoever with "Search entire record" (the forth option). Zebra gets the query:
@or @attr 1=Heading @attr 7=1 0 @attr 4=6 @attr 5=1 @attr 1=all <search term>
and answers ERROR 114, that is unknown use attribute. In fact, the attr-1 'all' is not defined. Before that patch 'all' was changed into @attr 1=Any. Now it seems to create problems.
Tests were done with 18.05.06.
Thank you for verifying this.
My fast work around is:
--- a/C4/AuthoritiesMarc.pm +++ b/C4/AuthoritiesMarc.pm @@ -163,6 +163,9 @@ sub SearchAuthorities { elsif ( @$tags[$i] eq "thesaurus" ) { $attr = " \@attr 1=Subject-heading-thesaurus "; } + elsif ( @$tags[$i] eq "all" ) { + $attr = " \@attr 1=Any "; + } else { # Use the index passed in params $attr = " \@attr 1=" . @$tags[$i] . " "; }
but I'm not sure if it wouldn't destruct the idea of the author of this patch, so I'm not submitting it.
Thanks for your work. But please open a new bug report, this one is already pushed to git branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962 [Bug 21962] Searching entire authority record failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #15 from Janusz Kaczmarek <januszop@gmail.com> --- Cf. Bug 21962 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org