[Bug 37639] New: items.stack ( shelving control number ) not included in items API endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Bug ID: 37639 Summary: items.stack ( shelving control number ) not included in items API endpoint Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com items.stack is not included at /api/v1/items/ I think it should be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170299&action=edit Bug 37639: Add items.stack to items endpoint To test: 1. Apply patch and restart_all 2. Check the items endpoint for items.stack ( http://localhost:8081/api/v1/items/144 ) 3. The data is there, and correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37637 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37637 [Bug 37637] Use the REST API to display items on the staff edit items view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170299|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170328&action=edit Bug 37639: Add items.stack to items endpoint To test: 1. Apply patch and restart_all, and yarn api:bundle 2. Check the items endpoint for items.stack ( http://localhost:8081/api/v1/items/144 ) 3. The data is there, and correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170329&action=edit Bug 37639: (follow-up) Remove stack from API mapping Shouldn't need to define stack in to_api_mapping because the name isn't changing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170328|0 |1 is obsolete| | --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170396&action=edit Bug 37639: Add items.stack to items endpoint To test: 1. Apply patch and restart_all, and yarn api:bundle 2. Check the items endpoint for items.stack ( http://localhost:8081/api/v1/items/144 ) 3. The data is there, and correct. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170329|0 |1 is obsolete| | --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170397&action=edit Bug 37639: (follow-up) Remove stack from API mapping Shouldn't need to define stack in to_api_mapping because the name isn't changing. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Why is items.stack the only column in items that doesn't have a comment in kohastructure.pl? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Paul Derscheid from comment #6)
Why is items.stack the only column in items that doesn't have a comment in kohastructure.pl?
It's a good question. There should be more info. on what it is. I had to ask around to find out. It is also one of the only ones without POD in Koha/Schema/Result/Item.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Paul Derscheid from comment #6)
Why is items.stack the only column in items that doesn't have a comment in kohastructure.pl?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37653 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just feeling that it would be better to list it (skip 2nd patch). Also note: withdrawn => 'withdrawn', timestamp => 'timestamp', location => 'location', uri => 'uri', Is it possible to add a tiny test to prove the result of this change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170397|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170458&action=edit Bug 37639: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> ---
Is it possible to add a tiny test to prove the result of this change?
I don't know how to write a test for my change only, so I added some for all the to_api_mappiings in Item.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. we add it to the mapping... As people are confused about 'stack'.. should we not actually map it to something more meaningful for the API field? control_number perhaps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #12)
OK.. we add it to the mapping... As people are confused about 'stack'.. should we not actually map it to something more meaningful for the API field?
control_number perhaps?
I think control_number might also be a bit difficult as it reminds of the MARC 001 label. shelving_control_number maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #13)
(In reply to Martin Renvoize from comment #12)
OK.. we add it to the mapping... As people are confused about 'stack'.. should we not actually map it to something more meaningful for the API field?
control_number perhaps?
I think control_number might also be a bit difficult as it reminds of the MARC 001 label. shelving_control_number maybe?
I'm happy to change the patch. Is 'shelving_control_number' agreed upon? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Martin is not around for a few days. If you agree, maybe move on with it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Sorry, but what exactly is this referring to? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Exposing items.stacks as shelving_control_number in the API (I believe). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Alright, I also think shelving_control_number sounds reasonable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sounds great to me.. it's a tiny ask but I think that would poke it into PQA for me 😀 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170782&action=edit Bug 37639: Map items.stack as shelving_control_number in API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- WARN t/db_dependent/api/v1/items.t WARN tidiness The file is less tidy than before (bad/messy lines before: 180, now: 225) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Failed test 'items.stack is mapped as stack in to_api_mapping' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 63. # got: 'shelving_control_number' # expected: 'stack' # Looks like you failed 1 test of 46. # Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 143. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #21)
WARN t/db_dependent/api/v1/items.t WARN tidiness The file is less tidy than before (bad/messy lines before: 180, now: 225)
My patchset doesn't touch these lines so I won't tidy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 172980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172980&action=edit Bug 37639: Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass (lukeg) from comment #23)
(In reply to Marcel de Rooy from comment #21)
WARN t/db_dependent/api/v1/items.t WARN tidiness The file is less tidy than before (bad/messy lines before: 180, now: 225)
My patchset doesn't touch these lines so I won't tidy.
What do you mean with these lines btw? Qa tools counts messy lines and tell us that your patch introduces 225-180 = 45 messy lines. The second patch adds 60+ lines to the test file. I suspect that all lines that are considered too long have been counted. So why are you stating that you did not touch these lines? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172980|0 |1 is obsolete| | --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 172988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172988&action=edit Bug 37639: Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #25)
(In reply to Lucas Gass (lukeg) from comment #23)
(In reply to Marcel de Rooy from comment #21)
WARN t/db_dependent/api/v1/items.t WARN tidiness The file is less tidy than before (bad/messy lines before: 180, now: 225)
My patchset doesn't touch these lines so I won't tidy.
What do you mean with these lines btw? Qa tools counts messy lines and tell us that your patch introduces 225-180 = 45 messy lines. The second patch adds 60+ lines to the test file. I suspect that all lines that are considered too long have been counted.
So why are you stating that you did not touch these lines?
I tidied them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #22)
# Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 143. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run.
Thanks for tidying. This test still fails with me with new line numbers: # Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 191. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run. Seeing warns in the log like: [WARN] OpenAPI >>> GET /api/v1/items [{"message":"Properties not allowed: shelving_control_number.","path":"\/body\/0"} etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #29)
(In reply to Marcel de Rooy from comment #22)
# Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 143. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run.
Thanks for tidying. This test still fails with me with new line numbers:
# Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 191. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run.
Seeing warns in the log like: [WARN] OpenAPI >>> GET /api/v1/items [{"message":"Properties not allowed: shelving_control_number.","path":"\/body\/0"} etc
Hmmm, I cannot make this failure happen locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass (lukeg) from comment #30)
(In reply to Marcel de Rooy from comment #29)
(In reply to Marcel de Rooy from comment #22)
# Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 143. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run.
Thanks for tidying. This test still fails with me with new line numbers:
# Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 191. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run.
Seeing warns in the log like: [WARN] OpenAPI >>> GET /api/v1/items [{"message":"Properties not allowed: shelving_control_number.","path":"\/body\/0"} etc
Hmmm, I cannot make this failure happen locally.
Maybe someone else can check too ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #32 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #29)
This test still fails with me with new line numbers:
# Failed test 'SWAGGER3.2.2' # at /usr/share/koha/t/db_dependent/api/v1/items.t line 191. # got: '500' # expected: '200' # Looks like you planned 15 tests but ran 5. # Looks like you failed 1 test of 5 run.
Seeing warns in the log like: [WARN] OpenAPI >>> GET /api/v1/items [{"message":"Properties not allowed: shelving_control_number.","path":"\/body\/0"}
You were missing the API spec bundle step: ```shell yarn api:bundle ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #33 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Lucas, I think there's been some miscommunication regarding this comment: (In reply to Marcel de Rooy from comment #9)
Just feeling that it would be better to list it (skip 2nd patch). Also note: withdrawn => 'withdrawn', timestamp => 'timestamp', location => 'location', uri => 'uri',
Is it possible to add a tiny test to prove the result of this change?
We never add tests for `to_api_mapping()` and my interpretation of Marcel's comment is that he doubts we need those specific mappings (which are dated a few years ago). I think we need to remove the tests and squash the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170396|0 |1 is obsolete| | Attachment #170458|0 |1 is obsolete| | Attachment #170782|0 |1 is obsolete| | Attachment #172988|0 |1 is obsolete| | --- Comment #34 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173615&action=edit Bug 37639: Add items.stack to items endpoint To test: 1. Apply patch and restart_all, and yarn api:bundle 2. Check the items endpoint for items.stack ( http://localhost:8081/api/v1/items/144 ) 3. The data is there, and correct. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173616&action=edit Bug 37639: (follow-up) Remove redundant mappings from Koha::Item::to_api_mapping() Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org