[Bug 38319] New: dt-select-filter makes some columns too wide on the detail page holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 Bug ID: 38319 Summary: dt-select-filter makes some columns too wide on the detail page holdings table Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: 1. Find a record with some items. 2. Notice the width of the entire table. 3. Click 'Show filters' 4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters. This can make for some wide tables, we can maybe just limit the width via CSS? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 173952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173952&action=edit Bug 38319: Control width of dt-select-filter To test: 1. Find a record with some items. 2. Notice the width of the entire table. 3. Click 'Show filters' 4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters. 5. APPLY PATCH, yarn build 6. Try again, the column width should stay the same. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173952|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 174316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174316&action=edit Bug 38319: Control width of dt-select-filter To test: 1. Find a record with some items. 2. Notice the width of the entire table. 3. Click 'Show filters' 4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters. 5. APPLY PATCH, yarn build 6. Try again, the column width should stay the same. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174469&action=edit Screenshot showing obscured selections A couple of things: 1. I would like this change to be moved to _tables.scss. That's where other DataTables style overrides are. 2. I'm happy for this fix because it has bugged me for a while, but I'm concerned about whether folks will object to the fact that they can't always read the whole string shown in the dropdown after a value has been selected. If it were up to me I'd say that the benefits outweigh the downsides here, but I'm curious if others have had user feedback about this kind of thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Setting to Failed QA for the _tables.scss choice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
2. I'm happy for this fix because it has bugged me for a while, but I'm concerned about whether folks will object to the fact that they can't always read the whole string shown in the dropdown after a value has been selected.
Good point here and this is something that is easy enough to adjust with IntranetUserCSS, so maybe we should leave as is and mark this WONTFIX? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Note that there are bug 36640 and bug 38310 in the queue ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38319 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
Note that there are bug 36640 and bug 38310 in the queue ;)
Let's set this one to resolved - WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org