http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don's show optgroup |Dont's show optgroup |Libraries when no search |Libraries when no search |groups are defined |groups are defined -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 18593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18593&action=edit [Signed-Off] Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an <optgroup>. <optgroup> should only be used to differentiate the list of individual libraries from search groups. This patch removes the <optgroup> when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration -> Libraries and Groups and enable it by checking the "show in search pulldown" box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into <optgroup>s. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no <optgroup>. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18593|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18732&action=edit Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an <optgroup>. <optgroup> should only be used to differentiate the list of individual libraries from search groups. This patch removes the <optgroup> when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration -> Libraries and Groups and enable it by checking the "show in search pulldown" box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into <optgroup>s. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no <optgroup>. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18735|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 18735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18735 [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl Wrong report. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.