[Bug 15739] New: Saving a new printer profile does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15739 Bug ID: 15739 Summary: Saving a new printer profile does not work Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org If you leave either the Printer Name or Paper Bin field empty (ie only putting something in one of those fields and leaving the other empty) then you will get a software error upon clicking Save Can't call method "save" without a package or object reference at /home/vagrant/kohaclone/patroncards/edit-profile.pl line 72. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15739 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> --- Granted the error trapping here and feedback to the user leaves much to be desired, however, the behavior is as expected. Looking here: http://tinyurl.com/z3t845z will show that what we do is run a parameter check when asked to create a new Profile object. If all required parameters are not passed in, rather than returning a new object, -1 is returned which causes the attempt to invoke the save method to fail. Its old code, and I never go back to adding proper error trapping. It really should not return -1 in any case. In light of that, this bug should probably be closed RESOLVED WORKSFORME and another opened which addresses error trapping in the labels/patroncards code in general. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org