https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34349 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159051|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159457&action=edit Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159457|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159465&action=edit Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I tested it on a new sandbox and it worked great. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159466|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161500&action=edit Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Bug 35350 depends on bug 35349, which changed state. Bug 35349 Summary: Reindent label item search template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35349 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.