[Bug 34405] New: Inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Bug ID: 34405 Summary: Inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the EDI accounts and library EAN page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add new account' to 'New account' - Add account ID (?), in single quotes, to Modify account? I'm not sure what makes sense here. - Add account ID (?), in single quotes, to Confirm deletion of account? I'm not sure what makes sense here. - Change 'Add new library EAN' to 'New library EAN' - Add EAN in single quotes to Modify library EAN - Add EAN in single quotes to Confirm deletion of EAN - Change EAN to library EAN in Confirm deletion of Breadcrumb - Change 'Add new account' to 'New account' - Add account ID (?) to Modify account? I'm not sure what makes sense here. - Add account ID (?) to Confirm deletion of account? I'm not sure what makes sense here. - Change 'Add new library EAN' to 'New library EAN' - Add EAN in single quotes to Modify library EAN - Add EAN in single quotes to Confirm deletion of EAN - Change EAN to library EAN in Confirm deletion of Page header - Styling of header for New account is different than usual - Styling of header for Modify account is different than usual - Add account ID (?) to Modify account? I'm not sure what makes sense here. - Add account ID (?) to Confirm deletion of account? I'm not sure what makes sense here. - Styling of header when adding a library EAN is different than usual - Add EAN in single quotes to Modify library EAN - Styling of header when modifying a library EAN is different than usual - Change 'Delete EAN code for branchname?' to 'Confirm deletion of library EAN code for branchname' - Add a condition so that 'for branchname' only appears if the EAN is for a specific library. Right now, an EAN for all libraries displays 'Delete EAN code for ?' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156612&action=edit Bug 34405: Fix inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and headers This patch fixes some inconsistencies in templates for EDI accounts and Library EANs, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and check these views: - Administration -> EDI accounts - New EDI account - Edit EDI account - Confirm deletion of EDI account - Administration -> Library EANs - New library EAN - Edit library EAN - Confirm deletion of EDI account - With an account for a specific library - With an account for any library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156612|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157246&action=edit Bug 34405: Fix inconsistencies in EDI accounts/Library EAN page titles, breadcrumbs, and headers This patch fixes some inconsistencies in templates for EDI accounts and Library EANs, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and check these views: - Administration -> EDI accounts - New EDI account - Edit EDI account - Confirm deletion of EDI account - Administration -> Library EANs - New library EAN - Edit library EAN - Confirm deletion of EDI account - With an account for a specific library - With an account for any library Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great consistency improvement. No regressions, simple good fix Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34405 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org