[Bug 13748] New: Acquisition wizard: some strings not translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Bug ID: 13748 Summary: Acquisition wizard: some strings not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Under Reports > Acquisition wizard appear 2 untranslatable strings in the pull downs: - All item types - All funds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- "All item types ": See reports/acquisitions/stats.pl line 128 "All funds": See line 147 Additionally, 'Collection code' seems not to be translated (first column), it is related to a variable $ccode_lable that is set in reports/acquisitions/stats.pl line 237, and this variable depends on GetMarcSubfieldsStructureFromKohaField (C4/Bilio.pm) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36768&action=edit Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36768|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36769&action=edit Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |766 Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 36775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36775&action=edit [Signed-off] Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36775|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36904&action=edit [PASSED QA] Bug 13748: Acquisition wizard: some strings not translatable This patch removes all instances of CGI::scrolling_list from reports/acquisitions_stats.pl, which prevented proper translation To test: 1) Install and enable a language (es-ES or de-DE are good choices) 2) On Acquisitons wizard, some pulldown labels are not translated 3) Apply the patch 4) Update and install again the language 5) Check labels are translated and all pulldown works This does not solve the 'Collection code' problem, is more strange Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, good improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org