[Bug 22301] New: Paying fines is broken when using CurrencyFormat = FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Bug ID: 22301 Summary: Paying fines is broken when using CurrencyFormat = FR Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 11373 Target Milestone: --- Using CurrencyFormat FR: When paying an amount the amount now shows with comma decimal instead of decimal dot. This creates big issues when trying to pay amounts correctly. For example: Trying to pay 9,55. Go into the input field and change 9 to 5, Koha will turn it into 555.00. Prices currently need to all be displayed with decimal dot in input fields. Please fix urgently. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Bug 22301 depends on bug 11373, which changed state. Bug 11373 Summary: Add "change calculation" feature to the fine payment forms https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Katrin, I cannot recreate: "Create manual invoice" with amount=9.55 "Pay fines" > "Pay amount" > "Collect from patron" 5.55 > Confirm I see "-5,55" in the table. https://snag.gy/KEMAIu.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Heh, let me update my outdated local repo :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85136&action=edit Bug 22301: (bug 11373 follow-up) Do not format amounts in inputs on_edition flag must be set when the Price plugin is used on inputs. Prices currently need to all be displayed with decimal dot in input fields. Test plan: Trying to pay 9,55. Go into the input field and change 9 to 5. Without this patch Koha will turn it into 555.00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- New QA check is going to be added, see https://gitlab.com/koha-community/qa-test-tools/issues/10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It changed on the fly in the form immediately after I went in and changed the number - might be a JavaScript thing on the form. I didn't save it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for fixing and so great to see you back! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85136|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85142&action=edit Bug 22301: (bug 11373 follow-up) Do not format amounts in inputs on_edition flag must be set when the Price plugin is used on inputs. Prices currently need to all be displayed with decimal dot in input fields. Test plan: Trying to pay 9,55. Go into the input field and change 9 to 5. Without this patch Koha will turn it into 555.00. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85142|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85154&action=edit Bug 22301: (bug 11373 follow-up) Do not format amounts in inputs on_edition flag must be set when the Price plugin is used on inputs. Prices currently need to all be displayed with decimal dot in input fields. Test plan: Trying to pay 9,55. Go into the input field and change 9 to 5. Without this patch Koha will turn it into 555.00. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA.. annoyed I missed it the first time round testing.. Great to here we're going to start catching it with a qa check, thanks for that Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug not in 18.11.x, marking RESOLVED FIXED. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org