[Bug 12209] New: Fix currency symbol for NOK
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Bug ID: 12209 Summary: Fix currency symbol for NOK Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql has: 22 INSERT INTO `currency` (currency, rate, symbol, active) VALUES 23 ('USD', 5.6157, '$', 0), 24 ('NOK', 1.0, '$', 1), 25 ('GBP', 8.9680, '£', 0), 26 ('EUR', 7.8940, '€', 0); The currency symbol for NOK is not $. Probably "kr"? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Magnus Enger from comment #0)
The currency symbol for NOK is not $. Probably "kr"?
Well, you would know best. How are NOK amounts typically written down? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Where is the patch? :) Wikipedia seems to agree with kr: http://en.wikipedia.org/wiki/Norwegian_krone -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- Thanks for caring about the Norwegian kroner, Katrin & Galen! :-) The question mark was mostly as a note to my future self, who will provide a patch, but maybe not today. ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 28271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28271&action=edit Bug 12209 - Fix currency symbol for NOK Dunno why, but the currency symbol for NOK was given as "$", when it should be "kr". To test: - Empty the "currency" table in the DB: DELETE FROM currency; - Load in the file changed by this patch: sudo koha-mysql <instance> < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql (if you are testing on a (gitified) package install) - Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl - Add a budget and a fund, and check that "kr" is displayed in the list of funds (currency symbols seem to be missing from the list of budgets) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28271|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28277&action=edit [SIGNED-PFF] Bug 12209 - Fix currency symbol for NOK Dunno why, but the currency symbol for NOK was given as "$", when it should be "kr". To test: - Empty the "currency" table in the DB: DELETE FROM currency; - Load in the file changed by this patch: sudo koha-mysql <instance> < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql (if you are testing on a (gitified) package install) - Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl - Add a budget and a fund, and check that "kr" is displayed in the list of funds (currency symbols seem to be missing from the list of budgets) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> file loads ok, kr currency active, no errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28277|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 28283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28283&action=edit [PASSED QA] Bug 12209 - Fix currency symbol for NOK Dunno why, but the currency symbol for NOK was given as "$", when it should be "kr". To test: - Empty the "currency" table in the DB: DELETE FROM currency; - Load in the file changed by this patch: sudo koha-mysql <instance> < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql (if you are testing on a (gitified) package install) - Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl - Add a budget and a fund, and check that "kr" is displayed in the list of funds (currency symbols seem to be missing from the list of budgets) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> file loads ok, kr currency active, no errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12209 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org