[Bug 15875] New: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 Bug ID: 15875 Summary: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt@gmail.com Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl z3950servers.pl is a horrible mess of hard SQL in the perl script/Controller-layer. Also a lack of proper internal API for mutating Z3950servers makes writing tests much harder. This patch refactors z3950servers.pl by moving SQL to C4::Breeding under proper accessors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15298 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 48268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48268&action=edit Bug 15875 - Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding z3950servers.pl is a horrible mess of hard SQL in the perl script/Controller-layer. Also a lack of proper internal API for mutating Z3950servers makes writing tests much harder. This patch refactors z3950servers.pl by moving SQL to C4::Breeding under proper accessors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- sub castCGIToZ3950serverParams { + my ($cgi) = @_; + + my $params = {}; + $params->{'host'} = $input->param('host'), Sure this is what you mean? :) cgi..inpuy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- horrible mess :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should now be written using objects in the Koha namespace instead of moving code into C4. Closing WONTFIX for now. I think a new bug would be better if this is tackled again according to current coding practice. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org