http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 26559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26559&action=edit Bug 11995: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Bug 7688 changes the prototype for GetNextDate. The serialsUpdate.pl cronjob script has not been updated. Test plan: Before applying the patch: 1/ Check that the following SQL query returns something: SELECT serial.* FROM serial LEFT JOIN subscription ON (subscription.subscriptionid = serial.subscriptionid) WHERE serial.status = 1 AND DATE_ADD(planneddate, INTERVAL CAST(graceperiod AS SIGNED) DAY) < NOW() AND subscription.closed = 0; 2/ Run misc/cronjobs/serialsUpdate.pl -v It should die with an error message like this: Can't use string ("2011-03-05") as a HASH ref while "strict refs" in use 3/ Apply the patch 4/ Run misc/cronjobs/serialsUpdate.pl -v It should exit normally and print messages like this: Serial issue with id=XX updated -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |7688 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #2)

Comment on attachment 26559 [details] [review]

...

my $subscription = &GetSubscription( $issue->{subscriptionid} ); + my $publisheddate = $issue->{publisheddate};

What is the difference between publisheddate and planneddate? This is the only thing holding me back from signing off.

publisheddate is the date of the publication and planneddate is the planned date of the reception (and becomes the date of the reception, when it has been done). Before bug 7688, the GetNextDate was called with planneddate sometimes and publisheddate other times. To get the next published date, it is logical to be based on the current published date (and not planneddate, which could be different for each library). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26559|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26940&action=edit [SIGNED OFF] Bug 11995: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Bug 7688 changes the prototype for GetNextDate. The serialsUpdate.pl cronjob script has not been updated. Test plan: Before applying the patch: 1/ Check that the following SQL query returns something: SELECT serial.* FROM serial LEFT JOIN subscription ON (subscription.subscriptionid = serial.subscriptionid) WHERE serial.status = 1 AND DATE_ADD(planneddate, INTERVAL CAST(graceperiod AS SIGNED) DAY) < NOW() AND subscription.closed = 0; 2/ Run misc/cronjobs/serialsUpdate.pl -v It should die with an error message like this: Can't use string ("2011-03-05") as a HASH ref while "strict refs" in use 3/ Apply the patch 4/ Run misc/cronjobs/serialsUpdate.pl -v It should exit normally and print messages like this: Serial issue with id=XX updated 5/ Run the Koha QA test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The only file modified is misc/cronjobs/serialsUpdate.pl The error is caused by switching the order of a hash and parameter. This also corrects the date used to be publisheddate instead of planneddate, because the latter does not logically predict the next one. See comment #3. The id=XX's listed in step 4 match the ids displayed by the SQL query in step 1. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26940|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27008&action=edit Bug 11995: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Bug 7688 changes the prototype for GetNextDate. The serialsUpdate.pl cronjob script has not been updated. Test plan: Before applying the patch: 1/ Check that the following SQL query returns something: SELECT serial.* FROM serial LEFT JOIN subscription ON (subscription.subscriptionid = serial.subscriptionid) WHERE serial.status = 1 AND DATE_ADD(planneddate, INTERVAL CAST(graceperiod AS SIGNED) DAY) < NOW() AND subscription.closed = 0; 2/ Run misc/cronjobs/serialsUpdate.pl -v It should die with an error message like this: Can't use string ("2011-03-05") as a HASH ref while "strict refs" in use 3/ Apply the patch 4/ Run misc/cronjobs/serialsUpdate.pl -v It should exit normally and print messages like this: Serial issue with id=XX updated 5/ Run the Koha QA test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The only file modified is misc/cronjobs/serialsUpdate.pl The error is caused by switching the order of a hash and parameter. This also corrects the date used to be publisheddate instead of planneddate, because the latter does not logically predict the next one. See comment #3. The id=XX's listed in step 4 match the ids displayed by the SQL query in step 1. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.