[Bug 24093] New: Sorting indicators broken on list contents view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Bug ID: 24093 Summary: Sorting indicators broken on list contents view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 23013 Bug 23013 removed some images files which were a dependency for the our previous implementation of DataTables. These image files were being used to indicate the (server-side) sorting direction of the lists contents view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 95736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95736&action=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95736|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 95738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95738&action=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95738|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95752&action=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Bug 24093 depends on bug 23013, which changed state. Bug 23013 Summary: Upgrade DataTables in the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org