[Bug 25707] New: Mappings update in bug 11529 causes data loss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Bug ID: 25707 Summary: Mappings update in bug 11529 causes data loss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Turns out the database update for this change causes unexpected changes to the "Koha to MARC mapping" (via the MARC frameworks) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105680&action=edit Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log This patch removes the update of marc frameworks from the updatedatabase script and warns the "MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |11529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I wouldn't say it causes data loss because the data is still in the MARC record but it causes... incorrect MARC to DB mappings? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mappings update in bug |Mappings update in bug |11529 causes data loss |11529 causes incorrect MARC | |to DB data flow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Cook from comment #2)
I wouldn't say it causes data loss because the data is still in the MARC record but it causes... incorrect MARC to DB mappings?
It overwrites existing mappings and they are not preserved, so the only way to recover is from backup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |nick@bywatersolutions.com CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |kyle@bywatersolutions.com Status|Signed Off |In Discussion --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- @Kyle I don't understand why are you taking out the WHERE condition. And the warning message could be more clear about why they are wrong, otherwise it just says 'go remap' to what?. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- The where condition was there to not warn the mappings that we attempted to update. We are no longer making this attempt so we want to list the whole table Something like: The keyword to marc mapping feature is no longer supported. Above find the mappings that had been defined in your system. You will need to remap any desired MARC fields to the Koha field you desire in the Koha to MARC mappings page under Administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #5)
The where condition was there to not warn the mappings that we attempted to update. We are no longer making this attempt so we want to list the whole table
I get it.
Something like: The keyword to marc mapping feature is no longer supported. Above find the mappings that had been defined in your system. You will need to remap any desired MARC fields to the Koha field you desire in the Koha to MARC mappings page under Administration
That reads better :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105771&action=edit Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log This patch removes the update of marc frameworks from the updatedatabase script and warns the "MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105772&action=edit Bug 25707: (QA follow-up) Clearer message about what's going on Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #3)
(In reply to David Cook from comment #2)
I wouldn't say it causes data loss because the data is still in the MARC record but it causes... incorrect MARC to DB mappings?
It overwrites existing mappings and they are not preserved, so the only way to recover is from backup.
Ohh I see what you mean. I thought you meant MARC data would be lost, but you're referring to the mapping data. That makes sense. Honestly, I didn't recover from the backups. I just reset the mappings to reasonable defaults. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #9)
(In reply to Nick Clemens from comment #3)
(In reply to David Cook from comment #2)
I wouldn't say it causes data loss because the data is still in the MARC record but it causes... incorrect MARC to DB mappings?
It overwrites existing mappings and they are not preserved, so the only way to recover is from backup.
Ohh I see what you mean. I thought you meant MARC data would be lost, but you're referring to the mapping data. That makes sense.
Honestly, I didn't recover from the backups. I just reset the mappings to reasonable defaults.
Since the mappings can be re-created, I wasn't thinking of it as data loss, since the valuable data (the MARC data) is still preserved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 CC| |aleisha@catalyst.net.nz --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.05.x, no backport. 19.05.x shouldn't be affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29268 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29268 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org