http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-12 12:26:05 UTC --- MARC21 probably has the same problem. Asking Christophe to take care of it too -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-05-12 13:34:54 UTC --- After checking, following the comment of Paul, no similar url link in MARC21slim2OAIDC.xsl, so nothing done about that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-05-12 15:18:27 UTC --- Created attachment 4085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4085 proposed patch for 3.4 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-12 20:52:42 UTC --- Christophe, (or any unimarc user) can you please attach a couple of UNIMARC records here, or point me to some, so I can test. The code looks fine at first glance, and applies to master cleanly. But Id like to give a proper test. Thank you (PS is Christophe the French version of Christopher?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #8 from Magnus Enger <magnus@enger.priv.no> 2011-05-13 08:08:25 UTC --- (In reply to comment #7)

So I suggest to create a new Web Services syspref, something like OAI-PMH:IdentifierBase, and to use it in XSL rather than OPACBaseURL.

I think this is what the OAI-PMH:archiveID is already used for? The description of this syspref is "Identify records at this site with the prefix ___" I have a live installation where OAI-PMH:archiveID = oai:bibkat.no:NO-1120127 and the resulting identifiers look like this: http://sksk.bibkat.no/cgi-bin/koha/oai.pl?verb=ListIdentifiers&metadataPrefix=oai_dc I'm not sure why you would want an identifier that includes http://, but it seems to me that using OPACBaseURL for it would work fine. PS. This part of UNIMARCslim2OAIDC.xsl looks overly hardcoded too: <xsl:when test="marc:subfield[@code='c']='MAIN'">Main Branch</xsl:when> <xsl:when test="marc:subfield[@code='c']='BIB2'">Library 2</xsl:when> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 08:39:23 UTC ---

PS. This part of UNIMARCslim2OAIDC.xsl looks overly hardcoded too:

<xsl:when test="marc:subfield[@code='c']='MAIN'">Main Branch</xsl:when> <xsl:when test="marc:subfield[@code='c']='BIB2'">Library 2</xsl:when>

It is an issue only if the OAI harverster need to sublocalize your ressources. It's rarely the case. But in this situation, you have to use Koha OAI server in extended mode and hand craft a local XSL. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 --- Comment #12 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 09:46:55 UTC --- (In reply to comment #11)

(In reply to comment #9)

...

If we want consistency, we must modify XSL to construct the same identifier.

That seems to make excellent sense! ;-)

So, it's up to the patch submitter to propose an updated version of his patch? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 --- Comment #14 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-05-13 14:02:39 UTC --- (In reply to comment #6)

Christophe, (or any unimarc user) can you please attach a couple of UNIMARC records here, or point me to some, so I can test. The code looks fine at first glance, and applies to master cleanly. But Id like to give a proper test.

Thank you

(PS is Christophe the French version of Christopher?)

Done Chris, and yes Christophe is Christopher in French... ;o) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 --- Comment #16 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 15:55:55 UTC ---

but about the url, in my opinion in UNIMARslim2OAID.xsl we have a hardcoded link not to go to OAI-PMH:IdentifierBase but to go to the biblio in the library site. I have transformed http://opac.mylibrary.org/bib/xxx because one of our customer have a specific adress, to avoid for each specific case a rewrite in the xsl file... eg if OPACBaseURL == mabase.com, with the patch we have http://mabase.com/bib/biblionumber. In your example Frederic, we'll not have http://mylibrary.tld.fr4589 but http://mylibrary.tld.fr/bib/4589... Perhaps I'm wrong, sorry in this case, but I am not aware about this syspref and OAI in general, could you explain me in this case.

As it has been said above, thanks to Magnus, the identifier is already in the result returned by Koha OAI server in the header section: <ListRecords> <record> <header> <identifier>MY-OAI-PREFIX-OAI:1</identifier> What you find here before the biblionumber comes from OAI-PMH:archiveID syspref. So for consistency purpose, the second identifier located in the dublin core could be the same. Another option could be to just remove it and rely only on the header identifier. This identifier could be a link back to Koha OPAC detail page. But there is no rule for that. Don't forget that if you have specific needs, you can operate the OAI server in extended mode and then use a local specific XSL file, and even several XSL, one per metadata format. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:49 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6334 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |RESOLVED Resolution| |WONTFIX -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.